Bug 908704 - Networking of the Nested VMs is blocked by the rule of the Parent VM
Summary: Networking of the Nested VMs is blocked by the rule of the Parent VM
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: vdsm
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.3.4
Assignee: Assaf Muller
QA Contact: Haim
URL:
Whiteboard: network
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-07 10:58 UTC by Lev Veyde
Modified: 2014-07-20 06:13 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Fedora 18 Engine and Host
Last Closed: 2013-09-23 07:26:58 UTC
oVirt Team: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 12833 0 None None None Never
oVirt gerrit 17678 0 None None None Never

Description Lev Veyde 2013-02-07 10:58:18 UTC
Description of problem:

Nested VMs can't communicate over network since the parent VM is created with a rule to block all communication, but from it's own MAC address.

Parent VM should be allowed to communicate using any of the nested VMs that it runs, in addition to it's own MAC.

VDSM hook must catch creation of the child (nested) VMs and update the filter accordingly.


Version-Release number of selected component (if applicable):


How reproducible:
Allways.

Steps to Reproduce:
1. Create parent VM
2. Create nested VM
3. Try to connect from the nested VM
  
Actual results:
Network connection is blocked.

Expected results:
Network connection should be allowed.

Additional info:

Comment 1 Dan Kenigsberg 2013-02-07 12:11:22 UTC
Yes, we know that mac-no-spoofing is not good for in-VM bonding or nested VMs. This is one of the reasons that a user can disable the feature per vNIC.

I should have though of that when you first described the issue to me.

I think that it would be a nice feature to have an API for updating the list of acceptable macs on the fly. In this way a future ovirt-engine-5.2 could communicate with the virt host running its VM prior to their startup, so that traffic from these VMs can flow out of the virt host.

Comment 2 Dan Kenigsberg 2013-02-07 13:54:22 UTC
(In reply to comment #1)
> Yes, we know that mac-no-spoofing is not good for in-VM bonding or nested
> VMs. This is one of the reasons that a user can disable the feature per vNIC.

I'm told that despite my smart-alec reasoning above, we do *not* have this as a per vNic feature. too bad.

Comment 3 Itamar Heim 2013-02-20 07:47:01 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Yes, we know that mac-no-spoofing is not good for in-VM bonding or nested
> > VMs. This is one of the reasons that a user can disable the feature per vNIC.
> 
> I'm told that despite my smart-alec reasoning above, we do *not* have this
> as a per vNic feature. too bad.

so sounds like we need a mac-no-spoofing custom property or checkbox, which only admins/special permission can set?
in the interim, sounds like a custom hook which unsets the mac-no-spoofing for hosts running virtual hosts is needed.

Comment 4 Dan Kenigsberg 2013-02-20 08:06:02 UTC
(In reply to comment #3)
> 
> so sounds like we need a mac-no-spoofing custom property or checkbox, which
> only admins/special permission can set?

yes - and it should better be per-vnic.

> in the interim, sounds like a custom hook which unsets the mac-no-spoofing
> for hosts running virtual hosts is needed.

Sounds like a good entry point for Assaf.

Comment 5 Assaf Muller 2013-03-17 08:26:35 UTC
As requested I wrote a hook that disables mac spoof filtering on a VM basis. It should solve the issue with nested VMs unable to communicate.

http://gerrit.ovirt.org/#/c/12833/

Comment 6 Dan Kenigsberg 2013-06-05 21:53:32 UTC
Once http://www.ovirt.org/Features/Device_Custom_Properties is implemented, we can easily make the macspoof filter of comment #5 vnic-specific, add a simple GUI for it, and close the bug.

Comment 7 Assaf Muller 2013-08-08 16:21:26 UTC
We merged a hook that does this VM-wide, and another hook that does this per vnic will be merged soon.

The question is - Do we want a GUI for this on the engine? If so someone should be assigned the work so it actually gets done.

Comment 8 Itamar Heim 2013-08-21 16:41:31 UTC
as RC is built, moving to ON_QA (hopefully did not catch incorrect bugs when doing this)

Comment 9 Itamar Heim 2013-09-23 07:26:58 UTC
closing as this should be in 3.3 (doing so in bulk, so may be incorrect)


Note You need to log in before you can comment on or make changes to this bug.