Bug 908788 - Review Request: perl-Perl-Stripper - Yet another PPI-based Perl source code stripper
Summary: Review Request: perl-Perl-Stripper - Yet another PPI-based Perl source code s...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-07 14:27 UTC by Petr Šabata
Modified: 2014-04-03 13:36 UTC (History)
3 users (show)

Fixed In Version: perl-Perl-Stripper-0.04-1.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-03 13:36:19 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2013-02-07 14:27:32 UTC
Spec URL: http://psabata.fedorapeople.org/pkgs/perl-Perl-Stripper/perl-Perl-Stripper.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-Perl-Stripper/perl-Perl-Stripper-0.04-1.fc18.src.rpm
Description: 
This module is yet another PPI-based Perl source code stripper. Its focus
is on customization and stripping significant information from source code.
Fedora Account System Username: psabata

Comment 1 Petr Pisar 2013-02-07 16:58:10 UTC
URL and Source0 are usable. Ok.
Source tar ball is original (SHA-256: ed134dec1e0735af5a872a2ff299837d973e23cc83e2da3e468c63696f655d13). Ok.
Summary verified from lib/Perl/Stripper.pm. Ok.
Description verified from lib/Perl/Stripper.pm. Ok.
License verified from LICENSE, lib/Perl/Stripper.pm, README. Ok.
No XS code, noarch BuildArch is Ok.

TODO: You can build-require `perl(vars)' for consistency (t/data/1.pl:4).

Test::Script is optional. Ok.

Test::Pod is not used. Ok.
Test::Pod::Coverage is not used. Ok.
Pod::Coverage::TrustPod is not used. Ok.

All tests pass. Ok.

$ rpmlint perl-Perl-Stripper.spec ../SRPMS/perl-Perl-Stripper-0.04-1.fc19.src.rpm ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm
drwxr-xr-x    2 root    root                        0 Feb  7 17:50 /usr/share/doc/perl-Perl-Stripper-0.04
-rw-r--r--    1 root    root                      366 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/Changes
-rw-r--r--    1 root    root                    18356 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/LICENSE
-rw-r--r--    1 root    root                     6467 Sep 27 04:53 /usr/share/doc/perl-Perl-Stripper-0.04/README
-rw-r--r--    1 root    root                     4443 Feb  7 17:50 /usr/share/man/man3/Perl::Stripper.3pm.gz
drwxr-xr-x    2 root    root                        0 Feb  7 17:50 /usr/share/perl5/vendor_perl/Perl
-rw-r--r--    1 root    root                    10787 Feb  7 17:50 /usr/share/perl5/vendor_perl/Perl/Stripper.pm

File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm | sort | uniq -c
      1 perl >= 1:5.010
      1 perl(Log::Any)
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(Moo)
      1 perl(PPI)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Perl::Stripper) = 0.04
      1 perl-Perl-Stripper = 0.04-1.fc19
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Perl-Stripper-0.04-1.fc19.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4936677). Ok.

Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 2 Petr Šabata 2013-02-08 09:57:08 UTC
(In reply to comment #1)
> TODO: You can build-require `perl(vars)' for consistency (t/data/1.pl:4).

This file is used for testing only, not actually executed, if I understand it correctly.

> Resolution: Package APPROVED.

Thank you.

---

New Package SCM Request
=======================
Package Name: perl-Perl-Stripper
Short Description: Yet another PPI-based Perl source code stripper
Owners: psabata jplesnik ppisar
Branches: f17 f18
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2013-02-08 13:41:44 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2013-02-08 14:30:18 UTC
Thank you.

Comment 5 Fedora Update System 2013-02-08 14:48:06 UTC
perl-Perl-Stripper-0.04-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Perl-Stripper-0.04-1.fc18

Comment 6 Fedora Update System 2013-02-08 14:48:29 UTC
perl-Perl-Stripper-0.04-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-Perl-Stripper-0.04-1.fc17

Comment 7 Fedora Update System 2013-02-19 01:25:13 UTC
perl-Perl-Stripper-0.04-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 8 Fedora Update System 2013-02-19 01:31:21 UTC
perl-Perl-Stripper-0.04-1.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.