Hide Forgot
Description of problem: check-large-docs.sh is supposed to check the size of doc directories that aren't in -doc subpackages. Whether or not the subpackage is a -doc one is done by the line: [[ $rpm = *doc ]] && continue However, the directories in rpms-unpacked are named as so: foo-doc-1.0.0-1.fc18.noarch.rpm Since the directories will never end in "-doc" even if they are -doc subpackages, the test will fail packages that have properly split the documentation. Version-Release number of selected component (if applicable): 0.3.1 How reproducible: Always. Steps to Reproduce: 1. Make an SRPM with a large -doc subpackage. 2. Run fedora-review on it. Actual results: The following test fails: Large documentation must go in a -doc subpackage. Expected results: The test should pass, as the documentation has been split into a -doc subpackage as required.
Could you re-check this with the version in updates-testing? Thanks!
(In reply to comment #1) > Could you re-check this with the version in updates-testing? > > Thanks! After installing the version in updates-testing, I get another error entirely, which does not appear to be related to the original bug: http://fpaste.org/BGmf/
Hm... I can't find that srpm anywhere (c++-gtk-utils). Could you provide a link so I can reproduce it? (yes, this ius something completely different and far worse IMHO)
(In reply to comment #3) > Hm... I can't find that srpm anywhere (c++-gtk-utils). Could you provide a > link so I can reproduce it? (yes, this ius something completely different > and far worse IMHO) The c++-gtk-utils SRPM is a work in progress that I'm planning to submit for a package review. I have put it up on my fedorapeople space so that you can test it with this issue: http://airwave.fedorapeople.org/c++-gtk-utils/c++-gtk-utils.spec http://airwave.fedorapeople.org/c++-gtk-utils/c++-gtk-utils-2.0.14-1.fc18.src.rpm
I have found the error: the filename is fed to a regex, and there the ++ in c++ are interpreted as regex repetition markers. This will take some time to figure out how to handle, though. Stay tuned.
Pushed a fix fro crash to devel branch. The check-large-docs remains to be investigated
(In reply to comment #6) > Pushed a fix fro crash to devel branch. The check-large-docs remains to be > investigated Let me know when it's ready for me to test. From a quick look though, the check-large-docs issue does not appear to be fixed in 0.4.0. The script, "check-large-docs.sh", is identical to the one in 0.3.1, and the naming of the directories in "rpms-unpacked" is also the same. Unless I'm missing something, the original issue remains.
It's fixed in devel branch in git and could be tested now. To do so, you need to checkout the devel version as described in the fedora-review wiki at https://fedorahosted.org/FedoraReview/ Otherwise, there is a new release 0.4.0-3 under way which will have these patches applied. It *might* make before the weekend, but don't hold your breath. Thanks for this valuable bug report!
fedora-review-0.4.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fedora-review-0.4.0-3.fc18
(In reply to comment #8) > It's fixed in devel branch in git and could be tested now. To do so, you > need to checkout the devel version as described in the fedora-review wiki at > https://fedorahosted.org/FedoraReview/ > > Otherwise, there is a new release 0.4.0-3 under way which will have these > patches applied. It *might* make before the weekend, but don't hold your > breath. After downloading and running the devel version, I can confirm that both the originally reported bug and the error encountered in 0.4.0 appear to have been fixed. > Thanks for this valuable bug report! Thanks for the valuable program! It has been very helpful to me in making my first .spec.
fedora-review-0.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fedora-review-0.4.0-3.fc17
Package fedora-review-0.4.0-3.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fedora-review-0.4.0-3.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-2184/fedora-review-0.4.0-3.fc17 then log in and leave karma (feedback).
fedora-review-0.4.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fedora-review-0.4.0-4.fc18
fedora-review-0.4.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fedora-review-0.4.0-4.fc17
fedora-review-0.4.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.4.0-4.el6
fedora-review-0.4.0-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.4.0-4.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.4.0-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.4.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc18
fedora-review-0.4.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.el6
fedora-review-0.4.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc19
fedora-review-0.4.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc17
fedora-review-0.4.1-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.4.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.