Bug 908899 - New definition of poll_through_vdsm function is not reflected in the rest of the code
Summary: New definition of poll_through_vdsm function is not reflected in the rest of...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Spacewalk
Classification: Community
Component: Clients
Version: 1.9
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Stephen Herr
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On: 907847
Blocks: space19
TreeView+ depends on / blocked
 
Reported: 2013-02-07 19:59 UTC by Stephen Herr
Modified: 2013-03-06 18:35 UTC (History)
1 user (show)

Fixed In Version: rhn-virtualization-5.4.44-1
Clone Of: 907847
Environment:
Last Closed: 2013-03-06 18:35:30 UTC
Embargoed:


Attachments (Terms of Use)

Description Stephen Herr 2013-02-07 19:59:15 UTC
+++ This bug was initially created as a clone of Bug #907847 +++

Description of problem:
rhn-virtualization-host-5.4.34-4.el6sat.noarch package introduces new parameter for function poll_through_vdsm that was not available in rhn-virtualization-host-5.4.14-8.el6sat.noarch:

/usr/share/rhn/virtualization/poller.py line 130
def poll_through_vdsm(server)
...

But rest of the code does not reflect that

/usr/share/rhn/virtualization/support.py line 85

if vdsm_enabled:
    domains = poller.poll_through_vdsm()



Version-Release number of selected component (if applicable):
rhn-virtualization-host-5.4.34-4.el6sat.noarch

How reproducible:
RHEV 3.1. hypervisor on RHEL6 host and rhn-virtualization-host-5.4.34-4-4.el6sat.noarch package from RHN Tool

Steps to Reproduce:
1. run rhn-profile-sync
  
Actual results:
Traceback (most recent call last):
  File "/usr/sbin/rhn-profile-sync", line 56, in <module>
    cli.run()
  File "/usr/share/rhn/up2date_client/rhncli.py", line 84, in run
    sys.exit(self.main() or 0)
  File "/usr/sbin/rhn-profile-sync", line 51, in main
    support.refresh()
  File "/usr/share/rhn/virtualization/support.py", line 82, in refresh
    domains = poller.poll_through_vdsm()
<type 'exceptions.TypeError'>: poll_through_vdsm() takes exactly 1 argument (0 given)


Expected results:
Finish without an error

Additional info:

Comment 1 Stephen Herr 2013-02-07 20:05:11 UTC
Spacewalk master commit: 5f8c84dcff4c4d942c9e52485e8821b166c1771a

Comment 2 Stephen Herr 2013-03-01 17:07:53 UTC
Marking bug as ON_QA since tonight's build of Spacewalk nightly is a release candidate for Spacewalk 1.9.

Comment 3 Stephen Herr 2013-03-06 18:35:30 UTC
Spacewalk 1.9 has been released.

https://fedorahosted.org/spacewalk/wiki/ReleaseNotes19


Note You need to log in before you can comment on or make changes to this bug.