Bug 908900 – CONFIG_SWIFT_STORAGE_HOSTS format handling is badly parsed

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 908900 - CONFIG_SWIFT_STORAGE_HOSTS format handling is badly parsed

Summary:	CONFIG_SWIFT_STORAGE_HOSTS format handling is badly parsed

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat OpenStack
Classification:	Red Hat
Component:	openstack-packstack (Show other bugs)
Sub Component:
Version:	2.0 (Folsom)
Hardware:	x86_64 Linux

Priority	medium Severity high
Target Milestone:	snapshot4
Target Release:	2.1
Assigned To:	Martin Magr
QA Contact:	Jaroslav Henner
Docs Contact:

URL:
Whiteboard:
Keywords:	Triaged

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2013-02-07 15:08 EST by Jaroslav Henner
Modified:	2013-03-21 14:23 EDT (History)
CC List:	3 users (show)

See Also:	908846
Fixed In Version:	openstack-packstack-2012.2.3-0.1.dev454
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2013-03-21 14:23:26 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2013:0671	normal	SHIPPED_LIVE	Moderate: openstack-packstack security and bug fix update	2013-03-21 18:22:21 EDT

Groups: None (edit)

Description Jaroslav Henner 2013-02-07 15:08:56 EST

Description of problem:

CONFIG_SWIFT_STORAGE_HOSTS is described as:
# A comma separated list of IP addresses on which to install the
# Swift Storage services, each entry should take the format
# <ipaddress>[/dev], for example 127.0.0.1/vdb will install /dev/vdb
# on 127.0.0.1 as a swift storage device, if /dev is omitted Packstack
# will create a loopback device for a test setup

Which means I cannot use any file outside of /dev.

ALso, anything behind the second slash seems to be ignored, so
CONFIG_SWIFT_STORAGE_HOSTS=1.2.3.2/vg_system/swift

will result in this in fstab:
/dev/vg_system	/srv/node/device2	ext4	noatime,nodiratime,nobarrier,user_xattr	0	0


Version-Release number of selected component (if applicable):
openstack-packstack-2012.2.2-0.8.dev346.el6ost.noarch


How reproducible:
1/1


Steps to Reproduce:
1. Follow the Description.
  

Actual results:


Expected results:
The config
CONFIG_SWIFT_STORAGE_HOSTS=1.2.3.2/dev/vg_system/swift

causes following in fstab
/dev/vg_system/swift	/srv/node/device2	ext4	noatime,nodiratime,nobarrier,user_xattr	0	0


Additional info:

Comment 2 Jaroslav Henner 2013-02-07 15:15:57 EST

See also BZ#908846

Comment 3 Derek Higgins 2013-02-21 09:05:36 EST

Fix for the multiple slash bug now posted upstream
https://review.openstack.org/22548

I'm not sure using devices outside of /dev would be a case we want to support but if you think it should can you open a different ticket as a RFE as this behavior was by design.

Comment 4 Derek Higgins 2013-02-21 10:59:38 EST

Wrong link, Martin Magr beat me to it
https://review.openstack.org/#/c/22296/

Comment 6 Jaroslav Henner 2013-03-12 08:20:11 EDT

Well done.

CONFIG_SWIFT_STORAGE_HOSTS=10.34.69.157/vg_test/lv1, 10.34.69.157/vg_test/lv2

resulted in 

/dev/mapper/vg_test-lv2 on /srv/node/device2 type ext4 (rw,noatime,nodiratime,nobarrier,user_xattr)
/dev/mapper/vg_test-lv1 on /srv/node/device1 type ext4 (rw,noatime,nodiratime,nobarrier,user_xattr)

Comment 9 errata-xmlrpc 2013-03-21 14:23:26 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0671.html

Note You need to log in before you can comment on or make changes to this bug.