Created attachment 695043 [details] screen shot showing the issue. Description of problem: JON throws Global uncaught exception when setting start date field = "00:00" and end date = "24:00". This message is not clear and we should provide more precise error message Version-Release number of selected component (if applicable): JON 3.1 How reproducible: Always Steps to Reproduce: 1. navigate to resource -> Monitoring tab -> press Advanced button -> enter incorrect start/end date/time -> for instance (02/08/2013 00:00 and 02/08/2013 24:00) 2. 3. Actual results: Globally uncaught exception at the top of the window Expected results: We should have more precise error message. Additional info:
I wasn't able to reproduce this. For me bad time ranges generated the expected warnings about begin time before end time. I suggest this be re-tested after the charting updates are merged in, as perhaps this was fixed already, or perhaps those charting changes have updated the range selection logic.
This is now broken in a different sense: if you enter 24:00 the widget automatically resets the date to 23:00. Similar for 24:32 which resets to 23:32 Assigning to Mike as he is working on this right now
This is the behavior of the TimeItem control. The isomorphic guys treat 24:00 as an out of bounds value and always move the hours beyond 23 back to 23. The largest valid value for the TimeItem is 23.59. This can be evidenced in this case: http://forums.smartclient.com/showthread.php?t=28868&highlight=timeItem+validation I will need to use a different control other than TimeItem.
Committed to master: 6a73a05 Replaced the TimeItem that allowed a 24:XX time format with two spinnerItems that control each domain independently 0-23 and 0-59. @jkremser can you review and check into release branch for jon3.2.1?
commit in release branch: 8c9d2ac39
Moving to ON_QA as available for testing in the following brew build: https://brewweb.devel.redhat.com//buildinfo?buildID=336752 Note: the installed version is still JON 3.2.0.GA by design and this represents part of the payload for JON 3.2.1 also known as cumulative patch 1 for 3.2.0.GA. How this will be delivered to customers is still being discussed.
Verified JON 3.2.1. "Advanced" button has changed to "Custom" ... new spinner controls do not allow for invalid ranges.
JON 3.2.1 released week of 5/5/2014