Bug 909365 - [RFE] ovirt-shell vnc console does not work with tigervnc client
Summary: [RFE] ovirt-shell vnc console does not work with tigervnc client
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ovirt-engine-cli
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Juan Hernández
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 907931
Blocks: 908016
TreeView+ depends on / blocked
 
Reported: 2013-02-08 15:59 UTC by Juan Hernández
Modified: 2013-02-19 01:33 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 907931
Environment:
Last Closed: 2013-02-19 01:33:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Juan Hernández 2013-02-08 15:59:23 UTC
+++ This bug was initially created as a clone of Bug #907931 +++

Description of problem:
the console command runs vncviewer <host>:<port> -passwdInput, but -passwdInput is not supported with tigervnc

Version-Release number of selected component (if applicable):
ovirt-engine-cli-3.2.0.9-1.fc18.noarch

How reproducible:
Always

Steps to Reproduce:
1. connect with ovirt-shell 
2. console <vmname> where vm has display set as VNC
  
Actual results:
no console is displayed

Expected results:
console is displayed

Additional info:
command run now is:
echo <ticket> | <host>::<port> -passwdInput

what would work is:
echo <ticket> | vncpasswd -f | vncviewer <host>::<port> -passwordFile /dev/stdin

relevant code is in /usr/lib/python2.7/site-packages/ovirtcli/platform/posix/vnc.py

--- Additional comment from Sander Hoentjen on 2013-02-06 15:21:35 EST ---

This is because in F18 the patch was dropped to add -passwdInput to vncviewer:
See: http://koji.fedoraproject.org/koji/buildinfo?buildID=365068
"""
* Fri Aug 17 2012 Adam Tkac <atkac redhat com> 1.2.80-0.1.20120905svn4996
- update to 1.2.80
- remove deprecated patches
 - tigervnc-102434.patch
 - tigervnc-viewer-reparent.patch
 - tigervnc11-java7.patch
- patches merged
 - tigervnc11-xorg111.patch
 - tigervnc11-xorg112.patch
"""
tigervnc-102434.patch is the patch that implemented -passwdInput:
http://pkgs.fedoraproject.org/cgit/tigervnc.git/commit/?id=5e164de8bf7b74db5b65e29123dd63b6fc6fd1fc

--- Additional comment from Sander Hoentjen on 2013-02-06 15:23:06 EST ---

Created attachment 694128 [details]
patch that solves the issue for me

--- Additional comment from Juan Hernández on 2013-02-08 04:03:52 EST ---

Sander, I think that this patch is worh adding upstream, would you consider pushing it to the upstream gerrit? Meanwhile I will apply it to the package.

--- Additional comment from Sander Hoentjen on 2013-02-08 04:57:38 EST ---

Juan: http://gerrit.ovirt.org/#/c/11857/

Comment 1 Fedora Update System 2013-02-08 16:07:17 UTC
ovirt-engine-cli-3.2.0.9-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ovirt-engine-cli-3.2.0.9-3.fc18

Comment 2 Fedora Update System 2013-02-09 11:23:03 UTC
Package ovirt-engine-cli-3.2.0.9-3.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ovirt-engine-cli-3.2.0.9-3.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-2171/ovirt-engine-cli-3.2.0.9-3.fc18
then log in and leave karma (feedback).

Comment 3 Fedora Update System 2013-02-19 01:33:48 UTC
ovirt-engine-cli-3.2.0.9-3.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.