Spec URL: http://people.valinux.co.jp/~yamahata/ryu/fedora/ryu.spec SRPM URL: http://kojipkgs.fedoraproject.org/work/tasks/5608/4945608/ryu-1.6-1.src.rpm Description: Ryu is an Operating System for Software Defined Networking This is my first package and I'm seeking for sponser. I'm one of Ryu development team. For what's ryu please visit http://www.osrg.net/ryu/ http://fedoraproject.org/wiki/Features/Ryu Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4945608 Fedora Account System Username: yamahata
Hi Isaku: Is good practice paste the rpmlint output in the reviews http://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint and make scratch builds and paste the link in the review https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds - %clean is not needed - BuildRoot is not needed - cleaning of buildroot in %install is not needed - %defattr is not needed - The use of %define is deprecated - The tag license is wrong (in this case should be ASL 2.0) - The tag vendor not needed in Fedora - Don't repeat the name of the package in the summary, it's redundant - If the package contains conf files in /etc must marked as %config take a look at the rpmlint output will give a better explanation to what I'm saying After fixing these problems, you should take a look at: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Convincing_someone_to_sponsor_you Kind Regards
(In reply to comment #1) Hi, thank you for review. I fixed the issues. Spec URL: http://people.valinux.co.jp/~yamahata/ryu/fedora/ryu.spec SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/2215/4952215/ryu-1.6-1.src.rpm koji task URL:http://koji.fedoraproject.org/koji/taskinfo?taskID=4952214 build result URL: http://kojipkgs.fedoraproject.org//work/tasks/2215/4952215/build.log rpmlint result: > $ rpmlint --version > rpmlint version 1.4 Copyright (C) 1999-2007 Frederic Lepied, Mandriva > $ rpmlint SPECS/ryu.spec SRPMS/ryu-1.6-1.src.rpm RPMS/noarch/ryu-1.6-1.noarch.rpm RPMS/noarch/ryu-doc-1.6-1.noarch.rpm > 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Your spec is invalid. 1)Why did you global many things? Just put ryu as %{name}, why %global name ryu? It's weird... 2)%global release 1 is wrong , you should not define this, please write 1%{?dist} to the release tag. Once you update the spec or package, bump the 1 to 2 or even higher. 3)Prefix: %{_prefix} I don't know why you add this? 4)Please take a look at python packaging guidelines,then modify the "python setup.py build" command. 5)Do not use %{buildroot} and $RPM_BUILD_ROOT in one spec, please choose only one of them. 6)Do not %files -f INSTALLED_FILES, please list all files manually
(In reply to Christopher Meng from comment #3) > Your spec is invalid. > > 1)Why did you global many things? > > Just put ryu as %{name}, why %global name ryu? > > It's weird... > > 2)%global release 1 is wrong , you should not define this, please write > 1%{?dist} to the release tag. Once you update the spec or package, bump the > 1 to 2 or even higher. > > 3)Prefix: %{_prefix} I don't know why you add this? > > 4)Please take a look at python packaging guidelines,then modify the "python > setup.py build" command. > > 5)Do not use %{buildroot} and $RPM_BUILD_ROOT in one spec, please choose > only one of them. > > 6)Do not %files -f INSTALLED_FILES, please list all files manually Christopher, instead of just saying: this is wrong and that is wrong, you should point ymht(???) to the right direction, as Eduardo already did. ymht: when specifying name: bla, there's no need to %global or %define name any more. The same applies to release, version, etc. python setup.py ... should be written %{__python} setup.py ...
(In reply to Matthias Runge from comment #4) Thank you for review and sorry for delayed reply. Here is the updated one. Changes - remove macro of name, version, unmangled_version, release - remove Prefix - $RPM_BUILD_ROOT-> buildroot - python setup.py => __python setup.py - don't use INSTALLED_FILES Spec URL: http://people.valinux.co.jp/~yamahata/ryu/fedora/ryu.spec SRPM URL: http://kojipkgs.fedoraproject.org//work/tasks/3430/5583430/ryu-2.1-1.src.rpm koji task URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=5583430 build result URL: http://kojipkgs.fedoraproject.org//work/tasks/3430/5583430/build.log rpmlint result: > $ rpmlint --version > rpmlint version 1.5 Copyright (C) 1999-2007 Frederic Lepied, Mandriva > $ rpmlint SPECS/ryu.spec SRPMS/ryu-2.1-1.src.rpm RPMS/noarch/ryu-2.1-1.noarch.rpm RPMS/noarch/ryu-doc-2.1-1.noarch.rpm > 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
I think you should change BuildRequires: python-setuptools-devel to BuildRequires: python-setuptools. And, can you explain this: # debian dash doesn't support pushd? Thanks.
Hello! What's the current status of this ticket?
(In reply to Peter Lemenkov from comment #7) > Hello! > What's the current status of this ticket? He needs a sponsor...
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days