Bug 909798 - Quota doesn't handle directory names with ','.
Summary: Quota doesn't handle directory names with ','.
Keywords:
Status: CLOSED DUPLICATE of bug 969461
Alias: None
Product: GlusterFS
Classification: Community
Component: quota
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: ---
Assignee: vpshastry
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-11 05:59 UTC by Vijay Bellur
Modified: 2014-08-11 23:22 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-07-11 15:34:07 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Vijay Bellur 2013-02-11 05:59:38 UTC
Description of problem:
Setting quota limit on a dir path containing ',' doesn't succeed. And also further commands fail.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Create any volume, enable quota and mount the volume.
2. Create a directory with ',' in its name (eg "dir,1") and set some limit on it.
3. Try some more quota commands on the volume (which of them all fail).
  
Actual results:
Quota limit is not set and further commands fail.

Expected results:
All quota command should succeed whether or not the file name contains ',' in it.

Comment 1 Amar Tumballi 2013-02-18 04:27:50 UTC
This is a known issue (well, not sure if we documented this), as we take multiple directories for quota limit, ',' is used to separate the 'directory:value' pairs.

We can fix it, but we will have to take down support for some other character to handle these options.

Let us know what are the possible characters which we don't need to handle.

Comment 2 vpshastry 2013-09-20 05:23:40 UTC
Change http://review.gluster.org/#/c/5952 brings the new design and this allows the directory names with ','.
Cause:
Earlier quota configuration was based on the path. So, we store the paths that are configured in the volfile with specific format using ',' as delimiter <path>:<hard-limit>,<path>:<hard-limit>,... So, the directory names with ',' causes the parser to go wrong.
In the new approach the quota is based on the inode (ie quota limit conf follows the directory with the rename). And we store the configuration differently and no more parser problems.

Comment 3 Niels de Vos 2014-07-11 15:34:07 UTC

*** This bug has been marked as a duplicate of bug 969461 ***


Note You need to log in before you can comment on or make changes to this bug.