Created attachment 695978 [details] suggested patch Suggested patch makes python3 version to be build as well.
Comment on attachment 695978 [details] suggested patch The %check fails in both python2 and 3 with: ImportError: No module named type.suite I believe this needs to be installed to work. Also, do we want the default to be python3? python3 is not the default version of python in F-19.
*** Bug 911936 has been marked as a duplicate of this bug. ***
Created attachment 698330 [details] Add python3-pyasn1 and python3-pyasn1-modules subpackages and update
Built with attachment 698330 [details] and passes all tests for both python2 and python3: DEBUG: + /usr/bin/python2 test/suite.py <snip> DEBUG: Ran 323 tests in 0.033s DEBUG: + /usr/bin/python3 test/suite.py <snip> DEBUG: Ran 562 tests in 0.075s Packages build fine on rawhide and rpmlint only outputs ignorable warnings: python3-pyasn1.noarch: W: spelling-error %description -l en_US codecs -> codes, coders, code's python3-pyasn1-modules.noarch: W: no-documentation python-pyasn1.noarch: W: spelling-error %description -l en_US codecs -> codes, coders, code's python-pyasn1.src: W: spelling-error %description -l en_US codecs -> codes, coders, code's python-pyasn1-modules.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 5 warnings.
Created attachment 698341 [details] Add python3-pyasn1 and python3-pyasn1-modules subpackages and update Use $RPM_BUILD_ROOT instead of %{buildroot} for consistency.
Is there anything you'd like me to change about the patch? As I said, all tests pass, and I'm happy to become a co-maintainer and apply this update myself. I have already requested permissions on pkgdb.
(In reply to comment #1) > Also, do we want the default to be python3? python3 is not the default > version of python in F-19. I certainly don’t this we should DEFAULT to python3, just to provide python3-pyasn1 package.
This works and seems to adhere to the suggestions at http://fedoraproject.org/wiki/Packaging:Python#Subpackages, in that both versions are built at the same time. It might be cleaner to split adding python 3 support from updating the upstream version into two patches. This isn't a show-stopper though. I'm not sure the package description needs to be updated, except perhaps to drop the future ASN.1 compiler reference.
Would you like me to do this in git or post up the split patches here?
(In reply to comment #9) > Would you like me to do this in git or post up the split patches here? you cannot (as of now) ... your commit rights have not been approved yet. Either Rob, other people on the package (or me or other provenpackager) can do it. Rob?
I'll apply the changes.
> I'll apply the changes. Ah excellent, thanks very much!
Hi again. I noticed you built and updated for rawhide. Thanks very much! Could you please do the same for Fedora 18? That would be much appreciated.
I think I'd want buy-in from those few packages that consume this before pushing it into F-18. There are quite a few changes since 0.1.2 and I don't want to break any existing packages.
> I think I'd want buy-in from those few packages that consume > this before pushing it into F-18. There are quite a few changes > since 0.1.2 and I don't want to break any existing packages. Sure, that makes sense. I might post a patch to build python3-pyasn1 at version 0.1.2 so that nothing breaks.
I see you just committed in F18 git a python3 subpackage. Thanks very much Rob! :)
python-pyasn1-0.1.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pyasn1-0.1.2-3.fc18
Package python-pyasn1-0.1.2-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-pyasn1-0.1.2-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-4049/python-pyasn1-0.1.2-3.fc18 then log in and leave karma (feedback).
python-pyasn1-0.1.2-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.