Spec URL: http://ralph.fedorapeople.org//python-pygeoip.spec SRPM URL: http://ralph.fedorapeople.org//python-pygeoip-0.2.5-1.fc18.src.rpm Description: Pure Python GeoIP API based on MaxMind's C-based Python API but the code itself is ported from the Pure PHP GeoIP API. Create your GeoIP instance with appropriate access flag. `STANDARD` reads data from disk when needed, `MEMORY_CACHE` loads database into memory on instantiation and `MMAP_CACHE` loads database into memory using mmap. import pygeoip gi = pygeoip.GeoIP('/usr/share/geoip/GeoIP.dat', pygeoip.MEMORY_CACHE) Country lookup >>> gi.country_code_by_name('google.com') 'US' >>> gi.country_code_by_addr('64.233.161.99') 'US' >>> gi.country_name_by_addr('64.233.161.99') 'United States' City lookup >>> gi = pygeoip.GeoIP('/usr/share/geoip/GeoLiteCity.dat') >>> gi.record_by_addr('64.233.161.99') { 'city': 'Mountain View', 'region_name': 'CA', 'area_code': 650, 'longitude': -122.0574, 'country_code3': 'USA', 'latitude': 37.419199999999989, 'postal_code': '94043', 'dma_code': 807, 'country_code': 'US', 'country_name': 'United States' } >>> gi.time_zone_by_addr('64.233.161.99') 'America/Los_Angeles' For more information, check out the full API documentation at http://packages.python.org/pygeoip.
New upstream release includes docs, readme, license, and tests. Spec URL: http://threebean.org/rpm/python-pygeoip.spec SRPM URL: http://threebean.org/rpm/python-pygeoip-0.2.6-1.fc18.src.rpm
I'll review this.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. NO, See below - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License LGPLv3+ OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream sha256sum: e86058479b3820bd08f51b64e22c59fe1ed45ec468d51d36acd5ed413e49e810 pygeoip-0.2.6.zip e86058479b3820bd08f51b64e22c59fe1ed45ec468d51d36acd5ed413e49e810 pygeoip-0.2.6.zip OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) NO, See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The %check part has $-style macros, please fix this before shipping it 2. python-pygeoip.noarch: W: spelling-error %description -l en_US instantiation -> instantiate, substantiation, installation python-pygeoip.noarch: W: spelling-error %description -l en_US mmap -> map, m map, mamma python-pygeoip.noarch: W: spelling-error %description -l en_US gi -> GI, guy, gee python-pygeoip.noarch: W: spelling-error %description -l en_US GeoIP -> George python-pygeoip.noarch: W: spelling-error %description -l en_US geoip -> George python-pygeoip.noarch: W: spelling-error %description -l en_US dat -> DAT, tad, sat python-pygeoip.noarch: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up python-pygeoip.noarch: W: spelling-error %description -l en_US google -> Google, goggle, googly python-pygeoip.noarch: W: spelling-error %description -l en_US addr -> add, adder, adds python-pygeoip.noarch: W: spelling-error %description -l en_US dma -> dam, ma, mad python-pygeoip.noarch: W: install-file-in-docs /usr/share/doc/python-pygeoip-0.2.6/INSTALL python3-pygeoip.noarch: W: spelling-error %description -l en_US instantiation -> instantiate, substantiation, installation python3-pygeoip.noarch: W: spelling-error %description -l en_US mmap -> map, m map, mamma python3-pygeoip.noarch: W: spelling-error %description -l en_US gi -> GI, guy, gee python3-pygeoip.noarch: W: spelling-error %description -l en_US GeoIP -> George python3-pygeoip.noarch: W: spelling-error %description -l en_US geoip -> George python3-pygeoip.noarch: W: spelling-error %description -l en_US dat -> DAT, tad, sat python3-pygeoip.noarch: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up python3-pygeoip.noarch: W: spelling-error %description -l en_US google -> Google, goggle, googly python3-pygeoip.noarch: W: spelling-error %description -l en_US addr -> add, adder, adds python3-pygeoip.noarch: W: spelling-error %description -l en_US dma -> dam, ma, mad python3-pygeoip.noarch: W: install-file-in-docs /usr/share/doc/python3-pygeoip-0.2.6/INSTALL 2 packages and 0 specfiles checked; 0 errors, 22 warnings. The spelling errors are to be expected. I would prefer that you did not ship INSTALL in the doc though. Please do not ship this package until geoip-geolite is shipped, or ship them together. Also, please fix the macro style in %check. Besides these, this package is APPROVED
New Package SCM Request ======================= Package Name: python-geoip Short Description: Pure Python GeoIP API Owners: ralph Branches: f19 f18 f17 el6 InitialCC:
Requested package name python-geoip doesn't match bug summary python-pygeoip, please correct.
Apologies.
New Package SCM Request ======================= Package Name: python-pygeoip Short Description: Pure Python GeoIP API Owners: ralph Branches: f19 f18 f17 el6 InitialCC:
Git done (by process-git-requests).
python-pygeoip-0.2.6-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pygeoip-0.2.6-1.fc18
python-pygeoip-0.2.6-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-pygeoip-0.2.6-1.fc17
python-pygeoip-0.2.6-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-pygeoip-0.2.6-1.el6
python-pygeoip-0.2.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
python-pygeoip-0.2.6-1.fc18 has been pushed to the Fedora 18 stable repository.
python-pygeoip-0.2.6-1.fc17 has been pushed to the Fedora 17 stable repository.
All stable.
Package Change Request ====================== Package Name: python-pygeoip New Branches: epel7 Owners: ralph
*** Bug 1155400 has been marked as a duplicate of this bug. ***