Bug 910391 - review request: gnome-mahjongg
Summary: review request: gnome-mahjongg
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 19
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Yanko Kaneti
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-12 14:28 UTC by Matthias Clasen
Modified: 2013-03-27 12:50 UTC (History)
5 users (show)

Fixed In Version: gnome-mahjongg-3.8.0-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-27 12:50:12 UTC
yaneti: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Matthias Clasen 2013-02-12 14:28:37 UTC
gnome-games has been broken up into individual modules upstream. We already had this split in our gnome-games package, but it is cleaner to have individual packages for each tarball. Here's the first one:

Spec: http://mclasen.fedorapeople.org/gnome-mahjongg.spec
SRPM: http://mclasen.fedorapeople.org/gnome-mahjongg-3.7.5-1.fc19.src.rpm
Description:
Mahjongg is a simple pattern recognition game. You score points by
matching identical tiles.

Comment 1 Yanko Kaneti 2013-02-13 08:28:34 UTC
The documentation license for mahjongg is actually CC-BY-SA so you have to:

-License:        GPLv2+ and GFDL
+License:        GPLv2+ and CC-BY-SA

Otherwise the source matches, package builds in mock, game works, rpmlint only says:

gnome-mahjongg.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-mahjongg-3.7.5/COPYING

Which I'll add to your upstream report about licensing.
https://bugzilla.gnome.org/show_bug.cgi?id=693495

APPROVED
I'll pester you later if you don't change the license before committing.

Comment 2 Kalev Lember 2013-03-23 13:31:46 UTC
Thanks for the review, Yanko!

New Package SCM Request
=======================
Package Name: gnome-mahjongg
Short Description: GNOME Mahjongg game
Owners: mclasen
Branches: f19
InitialCC:

Comment 3 Gwyn Ciesla 2013-03-23 13:51:51 UTC
Done.

Comment 4 Kalev Lember 2013-03-27 12:50:12 UTC
I have imported the package and updated the documentation license.


Note You need to log in before you can comment on or make changes to this bug.