Red Hat Bugzilla – Bug 910798
Review Request: perl-Text-Tabs+Wrap - Expand tabs and do simple line wrapping
Last modified: 2015-03-25 13:19:50 EDT
Spec URL: http://ppisar.fedorapeople.org/perl-Text-Tabs+Wrap/perl-Text-Tabs+Wrap.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Text-Tabs+Wrap/perl-Text-Tabs+Wrap-2012.0818-1.fc19.src.rpm
Text::Tabs performs the same job that the UNIX expand(1) and unexpand(1)
commands do: adding or removing tabs from a document.
Text::Wrap::wrap() will reformat lines into paragraphs. All it does is break
up long lines, it will not join short lines together.
Fedora Account System Username: ppisar
This package is intended for rawhide only. It will dual-live after sub-packaging the modules from perl.spec.
This package is uncertain license. Waiting on legal department.
After consulting with Red Hat Legal, we believe that this is a non-free license, because of the "Publicly redistributed modified versions must use a different name." clause.
Could you please ask the upstream to drop that clause?
So, here is final statement from upstream. He will change the license to this
> This module may be modified, used, copied, and redistributed at your own
> risk. Please do not publicly redistribute modified versions of this code as
> Text::Tabs that do not pass the unmodified Text::Tabs test suite.
Is it acceptable for Fedora?
This mentions only the Text::Tabs module. How about Text::Wrap? Does it still use the old 'uncertain license'?
Let's see what upstream will come up in next version with...
It seems that statement is worded differently from what upstream told the Free Software Foundation, where this wording was submitted:
This module may be modified, used, copied, and redistributed at your own
risk. Although allowed by the preceding license, please do not publicly
redistribute modified versions of this code with the name "Text::Tabs"
unless it passes the unmodified Text::Tabs test suite.
They're 99% the same, but the above wording makes it very very clear that the test suite restriction is optional. Fedora and the FSF strongly prefer this wording.
Upstream released new version with the to-FSF-communicated wording.
Spot, which identifier should I use the spec file?
Spec URL: https://ppisar.fedorapeople.org/perl-Text-Tabs+Wrap/perl-Text-Tabs+Wrap.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Text-Tabs+Wrap/perl-Text-Tabs+Wrap-2013.0523-1.fc23.src.rpm
Lifting FE-Legal. (Please thank upstream for resolving this issue amicably.)
Updated package with correct license tag is on the same address.
I'll take it.
Um, the License tag still states `FIXME: Waiting on legal department'.
Packaging looks good to me. Just update the License tag to TTWL and perhaps remove the extra empty line at the end of the file :)
I did not uploaded the package actually. Now it should be correct.
Yes, yes it is.
New Package SCM Request
Package Name: perl-Text-Tabs+Wrap
Short Description: Expand tabs and do simple line wrapping
Upstream URL: http://search.cpan.org/dist/Text-Tabs%2BWrap/
Owners: ppisar jplesnik psabata
Git done (by process-git-requests).
Thank you for the review and the repository.
perl-Text-Tabs+Wrap has been sub-packaged in perl-5.20.2-325.fc23.