Bug 911042 - Review Request: nodejs-node-uuid - Simple and fast generation of RFC4122 (v1 and v4) UUIDs for Node.js
Review Request: nodejs-node-uuid - Simple and fast generation of RFC4122 (v1 ...
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: T.C. Hollingsworth
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 911022 948659
  Show dependency treegraph
 
Reported: 2013-02-14 04:42 EST by Jamie Nguyen
Modified: 2013-04-20 15:26 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-04-19 00:59:25 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
tchollingsworth: fedora‑review+
pbabinca: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Jamie Nguyen 2013-02-14 04:42:58 EST
Spec URL: https://bugzilla.redhat.com/show_bug.cgi?id=911041
SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-node-uuid-1.4.0-1.fc18.src.rpm
Fedora Account System Username: jamielinux

Description:
This Node.js module provides simple and fast generation of RFC4122 (v1 and v4)
UUIDs. It runs in Node.js and all browsers and can also generate
cryptographically strong random numbers.
Comment 1 T.C. Hollingsworth 2013-04-04 21:59:07 EDT
This is a new dependency of nodejs-request.  I'll take the review.
Comment 2 T.C. Hollingsworth 2013-04-04 22:56:29 EDT
Everything looks good, fedora-review clean, Node.js guidelines met.

This package is APPROVED.
Comment 3 T.C. Hollingsworth 2013-04-04 23:02:07 EDT
Ugh, spoke too soon. There are a few concerning rpmlint warnings:

nodejs-node-uuid.noarch: W: devel-file-in-non-devel-package /usr/libexec/node-uuid/benchmark/benchmark-native.c
nodejs-node-uuid.noarch: E: wrong-script-interpreter /usr/libexec/node-uuid/benchmark/bench.gnu /opt/local/bin/gnuplot
nodejs-node-uuid.noarch: E: non-executable-script /usr/libexec/node-uuid/benchmark/bench.gnu 0644L /opt/local/bin/gnuplot

Do you really need to ship the benchmark stuff in the package?  It doesn't seem like it's really useful.

If so, it should probably be in a subpackage that has dependencies on gnuplot.  You'll also need to fix up the shebang and executable bit complained about above.
Comment 4 Jamie Nguyen 2013-04-05 06:01:06 EDT
> Do you really need to ship the benchmark stuff in the package?

Nope! Removed:

Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-node-uuid.spec
SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-node-uuid-1.4.0-2.fc18.src.rpm
Comment 5 T.C. Hollingsworth 2013-04-05 16:52:53 EDT
This package is APPROVED.  Thanks!
Comment 6 Jamie Nguyen 2013-04-05 17:00:57 EDT
New Package SCM Request
=======================
Package Name: nodejs-node-uuid
Short Description: Simple and fast generation of RFC4122 (v1 and v4) UUIDs for Node.js
Owners: jamielinux
Branches: f18 f19 el6
InitialCC:
Comment 7 Pavol Babinčák 2013-04-08 04:59:24 EDT
Git done (by process-git-requests).
Comment 8 Fedora Update System 2013-04-08 09:48:34 EDT
nodejs-node-uuid-1.4.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-node-uuid-1.4.0-2.fc19
Comment 9 Fedora Update System 2013-04-08 09:49:28 EDT
nodejs-node-uuid-1.4.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/nodejs-node-uuid-1.4.0-2.fc18
Comment 10 Fedora Update System 2013-04-08 11:59:57 EDT
nodejs-node-uuid-1.4.0-2.fc19 has been pushed to the Fedora 19 testing repository.
Comment 11 Fedora Update System 2013-04-19 00:59:27 EDT
nodejs-node-uuid-1.4.0-2.fc18 has been pushed to the Fedora 18 stable repository.
Comment 12 Fedora Update System 2013-04-20 15:26:03 EDT
nodejs-node-uuid-1.4.0-2.fc19 has been pushed to the Fedora 19 stable repository.

Note You need to log in before you can comment on or make changes to this bug.