Spec URL: https://bugzilla.redhat.com/show_bug.cgi?id=911041 SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-node-uuid-1.4.0-1.fc18.src.rpm Fedora Account System Username: jamielinux Description: This Node.js module provides simple and fast generation of RFC4122 (v1 and v4) UUIDs. It runs in Node.js and all browsers and can also generate cryptographically strong random numbers.
This is a new dependency of nodejs-request. I'll take the review.
Everything looks good, fedora-review clean, Node.js guidelines met. This package is APPROVED.
Ugh, spoke too soon. There are a few concerning rpmlint warnings: nodejs-node-uuid.noarch: W: devel-file-in-non-devel-package /usr/libexec/node-uuid/benchmark/benchmark-native.c nodejs-node-uuid.noarch: E: wrong-script-interpreter /usr/libexec/node-uuid/benchmark/bench.gnu /opt/local/bin/gnuplot nodejs-node-uuid.noarch: E: non-executable-script /usr/libexec/node-uuid/benchmark/bench.gnu 0644L /opt/local/bin/gnuplot Do you really need to ship the benchmark stuff in the package? It doesn't seem like it's really useful. If so, it should probably be in a subpackage that has dependencies on gnuplot. You'll also need to fix up the shebang and executable bit complained about above.
> Do you really need to ship the benchmark stuff in the package? Nope! Removed: Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-node-uuid.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-node-uuid-1.4.0-2.fc18.src.rpm
This package is APPROVED. Thanks!
New Package SCM Request ======================= Package Name: nodejs-node-uuid Short Description: Simple and fast generation of RFC4122 (v1 and v4) UUIDs for Node.js Owners: jamielinux Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
nodejs-node-uuid-1.4.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-node-uuid-1.4.0-2.fc19
nodejs-node-uuid-1.4.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-node-uuid-1.4.0-2.fc18
nodejs-node-uuid-1.4.0-2.fc19 has been pushed to the Fedora 19 testing repository.
nodejs-node-uuid-1.4.0-2.fc18 has been pushed to the Fedora 18 stable repository.
nodejs-node-uuid-1.4.0-2.fc19 has been pushed to the Fedora 19 stable repository.