Bug 911062 - Review Request: perl-Thread-Queue - Thread-safe queues
Summary: Review Request: perl-Thread-Queue - Thread-safe queues
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-14 09:56 UTC by Petr Pisar
Modified: 2013-03-01 13:28 UTC (History)
3 users (show)

Fixed In Version: perl-Thread-Queue-3.02-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-03-01 13:28:09 UTC
Type: ---
Embargoed:
emmanuel: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2013-02-14 09:56:58 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Thread-Queue/perl-Thread-Queue.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Thread-Queue/perl-Thread-Queue-3.01-1.fc19.src.rpm
Description:
This module provides thread-safe FIFO queues that can be accessed safely by
any number of threads.

Fedora Account System Username: ppisar


----
This package is intended for rawhide only. It will dual-live to provide newer version after sub-packaging from perl.spec.

Comment 1 Emmanuel Seyman 2013-02-28 18:19:06 UTC
Taking.

Comment 2 Emmanuel Seyman 2013-02-28 18:51:03 UTC
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===

 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5065282

 [x] Rpmlint output:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
None specified, default used

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
8f57305ef6df2c6281cedff10db86871  Thread-Queue-3.01.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===

 [!] Latest version is packaged.
Thread-Queue 3.02 has been released since this package was submitted.

 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5065282
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=11, Tests=304, 21 wallclock secs ( 0.10 usr  0.02 sys +  0.55 cusr  0.08 csys =  0.75 CPU)
Result: PASS

APPROVED

Comment 3 Petr Pisar 2013-03-01 09:05:39 UTC
New Package SCM Request
=======================
Package Name: perl-Thread-Queue
Short Description: Thread-safe queues
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2013-03-01 13:08:07 UTC
Git done (by process-git-requests).

Comment 5 Petr Pisar 2013-03-01 13:28:09 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.