I'm running the anaconda 19-6 image to test all the changes we made in https://bugzilla.redhat.com/show_bug.cgi?id=903501 . One of the changes we made was to let you go through 'reclaim space' even if you have sufficient free space available. As a consequence, we need to revise the 'reclaim space' page's wording a bit, as it was written with the assumption you'd only hit it if you didn't have enough space available. The one thing that clearly has to change is the first line of text under 'RECLAIM DISK SPACE' - it says "You don't have enough free space available for this installation", even if you do. We could possibly fiddle with the rest of the text, but we don't really have to. That's the only one that definitely has to change. Either we could just write something a bit more generic to cover both cases, or we could have two specific chunks of text and show the appropriate one. If we wanted to tweak the rest of the text a bit, there's "You can remove existing filesystems you no longer need to free up space for this installation" - "more space for this installation" might work a bit better now.
It also doesn't display how much free space you've already got, nor does it make the reclaim button sensitive to begin with.
Created attachment 703582 [details] This is what reclaim space looks like now, for the full context. there is additional text that appears in this dialog if you have shrinkable filesystems: "There is also free space available in pre-existing filesystems. While it's risky and we recommend you back up your data first, you can recover that free disk space and make it available for this installation below."
The full text then is: "You don't have enough free space available for this installation." "You can remove existing filesystems you no longer need to free up space for this installation. Removing a filesystem will permanently delete all of the data it contains." "There is also free space available in pre-existing filesystems. While it's risky and we recommend you back up your data first, you can recover that free disk space and make it available for this installation below." --- In which case, there's plenty of context to just nuke that first 'you don't have enough space' line.
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19
Tested with 19 Beta TC4. The text is now improved, but the two other issues Chris noted remain: "It also doesn't display how much free space you've already got, nor does it make the reclaim button sensitive to begin with." Both of those are still problems. BTW, maybe the button should be labelled Done in this version of the screen? It makes sense to have it always sensitive - so you can decide not to delete anything, and still continue - but it doesn't make sense to hit a button labelled Reclaim Space to escape the dialog if you will not in fact be reclaiming any space.
I believe with our latest round of changes, this bug can be closed. The Reclaim Space button is sensitive, and the amount of free space you've got can be inferred from looking at the "Free space..." lines in the display above. I don't think there's a place to put a single free space display without making this dialog even more complicated (it's already busier than I would like), nor do I think relabeling the button is going to do much for us.
the thing about relabelling the button was more a logic fix than a usability improvement, but I don't mind if you think it's not worth worrying about.