Bug 912309

Valiantsina, anything more specific about the examples that can help pinpoint exactly what's broken?

Hi Val,
   Yes, I need some more info on this. What exactly are you saying is broken? Are you referring to documentation inconsistencies only?

Hi Val,
   For some reason I can't view the attachment...BZ doesn't think I have the correct permissions. Could you email me the log?

Ok, in talking with Val, I believe I see the issue, at least in regards to the first point:

The documentation assumes that you will deploy a specific version of the adapter. Something like:

qpid-ra-0.18.rar

If you change the name of the adapter (which is the case) that part of the  documentation does not apply at this point. I believe Val was changing the name of the adapter and then adding XML from the documentation which at that point is rendered invalid as the name of the adapter has changed to something like qpid-ra.rar 

Note, just to be clear, qpid-ra-<ra-version>.rar is a placeholder and it assumes  <ra-version> will be replaced by the version from the provided RPM.

Ok, thanks to Val, we do have an issue with the JBOSS-README.txt file. I am working on an update and will attach when finished.

Created attachment 710590 [details]
README-JBOSS.txt

Updated README-JBOSS.txt to fix typos, incorrect values etc.

I have attached an updated README-JBOSS.txt file that cleans things up, corrects inconsistencies etc. A few high point:

1) The description of ra.xml versus *-ds.xml file has been reworked to be more
clean in that users typically never modify the ra.xml file directly. This was
unclear before and suggested that users had to modify this file.

2) The description and configuration of the LocalTransaction connection factory
has been removed. Originally we included this as a work around for XA/HA as
the broker did not allow for this. This has since been fixed and users should
not be using this ConnectionFactory directly as it's specialized and is used
by the application server and transaction manager to support the Last Resource Commit optimization. 

I think I caught all the typos and things are much clearer now. Also, I reviewed
the generic README.txt file which is more detailed in terms of the properties of the adapter (independent of any app server) and things seem ok. 

If I missed anything please let me know.

Changed initial paragraph in 12.5.2.1

also removed LocalConnection factory example.

 http://documentation-devel.engineering.redhat.com/docs/en-US/Red_Hat_Enterprise_MRG/2/html-single/Messaging_Installation_and_Configuration_Guide/index.html#sect-Deploying_the_Qpid_JCA_Adapter_on_JBoss_EAP_5

Please pay attention to 

2. JMS Queue Administered Object Example: example is broken. Please ask development for corrections.

3. JMS Topic Administered Object Example: example is broken. Please ask development for corrections.

4. In the description to examples in points 2. and 3., there is 'desinationAddress' referenced. According to  section 'QpidDestinationProxy Properties' , it should be 'DestinationAddress'.

vhubeika, when you say the example is broken, can you please give the steps to reproduce your experience. It's difficult to know what is missing / going wrong without some context.

Weston, can you give some guidance on this?

Joshua,

1. In the README-JBOSS.txt attached by Weston on 2013-03-15, the examples are reworked and shall be in a working state as provided except a wrong JNDA name in the JMS Queue Administered Object Example. For your convenience, I copy in the comment this examples with a corrected JNDA name:



  <mbean code="org.jboss.resource.deployment.AdminObject"
         name="qpid.jca:name=HelloQueue">
     <attribute name="JNDIName">HelloQueue</attribute>
     <depends optional-attribute-name="RARName">jboss.jca:service=RARDeployment,name='qpid-ra-<ra-version>.rar'</depends>
     <attribute name="Type">org.apache.qpid.ra.admin.QpidQueue</attribute>
     <attribute name="Properties">
        DestinationAddress=amq.direct
     </attribute>
  </mbean>

The above XML defines a JMS Queue which is bound into JNDI as

HelloQueue


-----  and  -----

  <mbean code="org.jboss.resource.deployment.AdminObject"
         name="qpid.jca:name=HelloTopic">
     <attribute name="JNDIName">HelloTopic</attribute>
     <depends optional-attribute-name="RARName">jboss.jca:service=RARDeployment,name='qpid-ra-<ra-version>.rar'</depends>
     <attribute name="Type">org.apache.qpid.ra.admin.QpidTopic</attribute>
     <attribute name="Properties">
        DestinationAddress=amq.topic
     </attribute>
  </mbean>

The above XML defines a JMS Topic which is bound into JNDI as

HelloTopic

 

2. Please also note that point 2) in the comment 13 is no longer true due to BZ923202 and we will require the LocalConnection factory example back in the documentation.

http://documentation-devel.engineering.redhat.com/docs/en-US/Red_Hat_Enterprise_MRG/2/html-single/Messaging_Installation_and_Configuration_Guide/index.html#sect-JCA_Configuration_on_JBoss_EAP_5

Queue and Topic examples updated. LocalConnection Factory example added back in.

Please pay attention to 

1. In Comment 17 , example JMS Queue Administered Object, correct the JNDI name :

"The above XML defines a JMS Queue which is bound into JNDI as

HelloQueue"


2. Original Point 4. In the description to examples in point 3., there is 'desinationAddress' referenced. According to  section 'QpidDestinationProxy Properties' , it should be 'DestinationAddress'.

Thanks for picking that up - I was searching for "destinationAddress" and couldn't find it.

I am republishing the book. It takes up to 30 minutes to appear on the stage. The new version will have "QE Build 3, incorporating BZ#912309" in the Revision History.

checked & verified

Hi Val,
   Quick question. I am not able to follow why we added the LocalConnectionFactory  info back in. Could you explain?

hi Weston,

as it was decided that XA will not be supported with a cluster and documentation says :

The Qpid C++ broker does not support the use of XA within the context of clustered brokers. If you are running a cluster, you must configure the adapter to use LocalTransactions. 

we need to keep the Local Connection Factory example .

Yep, ok, your absolutely correct. I knew it was something simple. Mea culpa.