Description of problem: Kmix eats a lot of memory after a long use. Version-Release number of selected component (if applicable): kmix-4.10.0-1.fc18.x86_64 How reproducible: Just use your computer for some time. Actual results: Kmix uses a lot of memory, even around 400MB. Expected results: Kmix uses normal amount of memory.
For comparision, on my f18/x86_64 box, system activity reports for kmix: Memory: 32,184k Shared Mem: 10,604k How are you measuring memory usage?
I'm using ksysguard. I just found out that switching songs in Clementine increases memory usage of kmix. Now uses 70MB of memory.
It seems it's a bug in PA, when I disabled it, kmix uses the same amount of memory.
This is not new in 4.10, is it? Can we take this off the blocker tracker?
Taking this off the 4.10 tracker.
Looks like http://commits.kde.org/kde-workspace/984b9c4ad6b35fa07019e4d4d083e07749482a29 has the right fix
I pulled that in * Wed Jun 26 2013 Rex Dieter <rdieter> 4.10.4-6 - kmix: media track change memory leaks with pulseaudio+oxygen widget style (kde#309464, #912457) but, followup comment https://bugs.kde.org/show_bug.cgi?id=309464#c100 based on a conversation I had with apachelogger, looks like that's not the correct fix afterall. :(
It seems to be okay with Fedora 19. The reason is probably that F19 has newer version of PulseAudio. [root@fedora jgrulich]# rpm -q pulseaudio pulseaudio-3.0-10.fc19.x86_64
I still leaked for me, last I'd tested on f19 too. Are you sure?
I can switch songs arbitrarily and KMix still uses the same amount of memory (~ 19Mb). Before it grew what song to + ~0.5Mb.
Just to be paranoid: rpm -q kde-workspace kmix please and I'll retest myself (or anyone else, I'd like confirmation).
[root@fedora jgrulich]# rpm -q kde-workspace kmix kde-workspace-4.10.4-6.fc19.x86_64 kmix-4.10.4-1.fc19.x86_64
right, see comment #7 where I pulled in (the apparently wrong) upstream fix. apachelogger thinks that fix trades a memleak for an occasional crash. :(
I must say I agree with him, changing a deleteLater to a delete looks scary to me. It only makes sense when you really know what you're doing, which I had assumed the author of the patch did when I had seen the diff in the commit, but the patch has now been reverted upstream, so that assumption looks no longer valid. We should remove the patch ASAP. The code was probably using deleteLater for a reason. In fact, the typical fix to use-after-free bugs is to change the delete to a deleteLater. I agree with apachelogger that we really need to find out why deleteLater is not working in KMix. The offending patch is all the more scary as it's a global Oxygen change, not specific to KMix, so it can cause crashes all over KDE!
kmix-4.10.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/kmix-4.10.5-2.fc19
Package kmix-4.10.5-2.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kmix-4.10.5-2.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-13061/kmix-4.10.5-2.fc19 then log in and leave karma (feedback).
kmix-4.10.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kmix-4.10.5-2.fc18
kmix-4.10.5-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
kmix-4.10.5-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.