Bug 912642
| Summary: | [Admin Portal] 'Guide Me' dialog still shows 'Configure Network Interfaces' just one has been added | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Jiri Belka <jbelka> | ||||
| Component: | ovirt-engine-webadmin-portal | Assignee: | Lior Vernia <lvernia> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Meni Yakove <myakove> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 3.2.0 | CC: | acathrow, bazulay, ecohen, iheim, jbelka, jkt, lpeer, masayag, myakove, Rhev-m-bugs, yeylon | ||||
| Target Milestone: | --- | Keywords: | Triaged | ||||
| Target Release: | 3.3.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | network | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-10-20 05:51:15 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1019461 | ||||||
| Attachments: |
|
||||||
(In reply to comment #0) > Comparison of the dialog what happens when you do this: > * new VM, add network interface -> dialog still looks same Indeed needs to move to the optional section > * new VM, first add disk, disk button is gray for another optional addition, > network interface still un-configured It should be allowed to add as many disk as required from this dialogue Bug owner please fix both not to have to split the bug into teams. + the configure-later button should change to 'Done' (Jiri there should be an RFE on that, if you can't find open one) if the required operation list is empty - in this dialogue it means VM now has at-least one Disk and one Network. Well, now that users can add and remove VNICs as they wish in the new VM dialog, I think that the network interfaces may be removed from the guide me sequence altogether. Opinions? RHEVM does force you to have a network device, you cannot tell him you do not want one in new VM dialog as there is no option for this. This is maybe handy in 99% situations but where is the freedom to choose? (Although then I can remove this network device.) I agree with comment #2 but an option not to add network device would be good. I'm sorry, when I said "now" I meant patches that haven't made it into RHEV yet :) By next week's build you should be able to add and remove VNICs in the new VM dialog (and you'll also be able to create a VM with no interfaces if you wish). So in this case, is the network interface part of the guide me really needed anymore? Jiri, I just tested this on is18 and it seems to work for me. Possible that something has changed since you posted the bug. Steps: 1. Add VM from Blank template without any NICs. 2. In Guide Me dialog, configure interface as part of required actions. 3. After interface is added, Guide Me button changes to add another interface under optional actions, as I would have expected... Could you confirm? Yes, behaviour described in comment #5 is OK now (is19), even the original issue does not exist any more. So patches described in comment #4 obviously were merged. Feel free to close as CURRENTRELEASE. Seems to have been fixed sometime in the past (not related to what's mentioned in Comment #4). |
Created attachment 699389 [details] engine.log Description of problem: VM's 'Guide Me' dialog still shows 'Configure Network Interfaces' just one has been added, I would instead expect to see 'Add another Network Interface'. It seems adding a network interface doesn't "mark" this device type to be "configured" for this opened dialog instance. Adding a network interface also makes following two events (why 2 events?): 2013-Feb-19, 10:42 Interface <UNKNOWN> (Red Hat VirtIO) was added to VM vvv. (User: admin@internal) 2013-Feb-19, 10:42 Network Interface nic1 (Red Hat VirtIO) activated for VM vvv. (User: admin@internal) Comparison of the dialog what happens when you do this: * new VM, add network interface -> dialog still looks same * new VM, first add disk, disk button is gray for another optional addition, network interface still unconfigured Version-Release number of selected component (if applicable): sf7 (same even in si26.1) How reproducible: 100% Steps to Reproduce: 1. new VM 2. in Guide Me dialog, add network interface 3. check Guide Me dialog Actual results: after network interface has been added, the first action is still to add network interface under header 'Required actions:'. Expected results: after first network interface has been added, this device type should be internally marked as "configured", button should change to gray and move to optional action, in the top should be action for disk addition Additional info: New VM - Guide Me dialog -> Add network interface, now closing the dialog and opening again makes the action for adding network interface optional. So the marking of already added network interfaces seems to be issue only when the dialog is newly opened. After you add first network interface and you ignore the fact that network interface is still part of required actions and you logically add the disk, when the disk is added both device types become gray as optional.