Bug 912986
| Summary: | fencing: Fake "Error: system rebooted 2 times" message | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Hardware Certification Program | Reporter: | Caspar Zhang <czhang> | ||||
| Component: | Test Suite (harness) | Assignee: | Caspar Zhang <czhang> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 1.7.0 | CC: | bbrock, czhang, gnichols, qcai, rlandry | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | v7-1.7.0-R10 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-03-28 06:21:20 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 904887 | ||||||
| Attachments: |
|
||||||
Created attachment 700132 [details]
continuation.py patch removing extrainious print in reboot counting
Committed to R10 |
Description of problem: Sometimes, fake error message: "Error: system rebooted 2 times" will be printed in fencing test. like this example: [snip of /var/log/messages] Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Adding Task: v7 daemon run --agentUser <USERNAME> --agentPassword <PASSWORD> --agentType ilo --results 1 --agentIP <FQDN> --subtest powercycle --test fencing Feb 20 01:45:56 hp-dl360g5-01 v7[980]: opened task file Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Reading Results: Feb 20 01:45:56 hp-dl360g5-01 v7[980]: </pre><hr><pre> Feb 20 01:45:56 hp-dl360g5-01 v7[980]: <output> Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Server side test for fencing Feb 20 01:45:56 hp-dl360g5-01 v7[980]: running: fence_ilo -a <FQDN> -l <USERNAME> -p <PASSWORD> -o off Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Success: Powered OFF Feb 20 01:45:56 hp-dl360g5-01 v7[980]: running: fence_ilo -a <FQDN> -l <USERNAME> -p <PASSWORD> -o status Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Status: OFF Feb 20 01:45:56 hp-dl360g5-01 v7[980]: running: fence_ilo -a <FQDN> -l <USERNAME> -p <PASSWORD> -o on Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Success: Powered ON Feb 20 01:45:56 hp-dl360g5-01 v7[980]: <summary>PASS</summary> Feb 20 01:45:56 hp-dl360g5-01 v7[980]: </output> Feb 20 01:45:56 hp-dl360g5-01 v7[980]: </pre><hr><pre> Feb 20 01:45:56 hp-dl360g5-01 v7[980]: done Feb 20 01:45:56 hp-dl360g5-01 v7[980]: </pre> Feb 20 01:45:56 hp-dl360g5-01 v7[980]: reboot took 00:05:00 Feb 20 01:45:56 hp-dl360g5-01 v7[980]: method: powercycle Feb 20 01:45:56 hp-dl360g5-01 v7[980]: kernel: 3.7.0-0.33.el7.x86_64 vvvvvvvvvvvv where problem happens vvvvvvvvvvvvvvvvvvvvvv Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Feb 20 01:40:06 hp-dl360g5-01 v7[946]: Feb 20 01:39:31 hp-dl360g5-01 kernel: [ 0.000000] Linux version 3.7.0-0.33.el7.x86_64 (mockbuild.eng.bos.redhat.com) (gcc version 4.7.2 20121109 (Red Hat 4.7.2-8) (GCC) ) #1 SMP Fri Jan 25 18:07:32 EST 2013 Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Feb 20 01:45:37 hp-dl360g5-01 kernel: [ 0.000000] Linux version 3.7.0-0.33.el7.x86_64 (mockbuild.eng.bos.redhat.com) (gcc version 4.7.2 20121109 (Red Hat 4.7.2-8) (GCC) ) #1 SMP Fri Jan 25 18:07:32 EST 2013 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Feb 20 01:45:56 hp-dl360g5-01 v7[980]: Error: system rebooted 2 times Please see the above quoted lines, v7 prints the test output to /var/log/message, and in v7 code: 98 for line in log.split('\n'): 99 if "kernel:" in line and self.systemLogBootMarker in line: 100 print line 101 rebootCount += 1 between system log boot markers, v7 checks whether a line marked with "kernel:" exists. In this example, the first line is just a test output quoted by v7, not an actual kernel marker, but it's still counted. We should avoid such false alarm. This is not a problem in fencing test side, but a problem in continuation.py. Version-Release number of selected component (if applicable): 1.7.0-R9 How reproducible: frequent Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: