Spec URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository.spec SRPM URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository-0.0.14-1.fc15.src.rpm Description: Provides a database of test results which can be used to support easy developer workflows, supporting functionality like isolating failing tests. Testrepository is compatible with any test suite that can output subunit. This includes any TAP test suite and any pyunit compatible test suite. Fedora Account System Username: pbrady
Spec URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository.spec SRPM URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository-0.0.15-1.fc18.src.rpm Description: Provides a database of test results which can be used to support easy developer workflows, supporting functionality like isolating failing tests. Testrepository is compatible with any test suite that can output subunit. This includes any TAP test suite and any pyunit compatible test suite. Fedora Account System Username: pbrady
1/ Running fedora-review tool against rawhide fails w/ RPM build errors: $ fedora-review -m fedora-rawhide-x86_64 --rpm-spec -n ../SRPMS/python-testrepository-0.0.15-1.fc18.src.rpm fails with: (from - /home/kashyap/rpmbuild/SPECS/python-testrepository/results/build.log) ---------- . . Traceback (most recent call last): File "setup.py", line 16, in <module> from setuptools import setup ImportError: No module named setuptools RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.w0YBti (%build) Bad exit status from /var/tmp/rpm-tmp.w0YBti (%build) Child return code was: 1 EXCEPTION: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/python-testrepository.spec'] Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 359, in do raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode) Error: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/python-testrepository.spec'] LEAVE do --> EXCEPTION RAIS ---------- Is the above due to python-3/python-2 ? 2/ However, running against Fedora-18, succeeds: ---------- $ fedora-review --rpm-spec -n ../SRPMS/python-testrepository-0.0.15-1.fc18.src.rpm INFO: Processing local files: ../SRPMS/python-testrepository-0.0.15-1.fc18.src.rpm INFO: Getting .spec and .srpm Urls from : Local files in /home/kashyap/rpmbuild/SPECS INFO: --> SRPM url: file:///home/kashyap/rpmbuild/SRPMS/python-testrepository-0.0.15-1.fc18.src.rpm INFO: Using review directory: /home/kashyap/rpmbuild/SPECS/python-testrepository INFO: --> Spec url: file:///home/kashyap/rpmbuild/SPECS/python-testrepository/srpm-unpacked/python-testrepository.spec INFO: Downloading (Source0): http://pypi.python.org/packages/source/t/testrepository/testrepository-0.0.15.tar.gz INFO: Running checks and generating report INFO: Results and/or logs in: /home/kashyap/rpmbuild/SPECS/python-testrepository/results INFO: WARNING: Probably non-rawhide buildroot used. Rawhide should be used for most package reviews INFO: Build completed INFO: Installing built package(s) INFO: Install command returned error code 30 INFO: Starting new HTTPS connection (1): admin.fedoraproject.org INFO: Starting new HTTPS connection (1): admin.fedoraproject.org Review template in: /home/kashyap/rpmbuild/SPECS/python-testrepository/review.txt fedora-review is automated tool, but *YOU* are responsible for manually reviewing the results and finishing the review. Do not just copy-paste the results without understanding them. ---------- Proceeding with manual review with the above.
Posting the result of fedora-review tool. Manual review upcoming... kashyap@SPECS$ cat /home/kashyap/rpmbuild/SPECS/python-testrepository/review.txt Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Package complies to the Packaging Guidelines [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SPECS/python- testrepository/licensecheck.txt [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 1.1.29 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.29 INFO: Mock Version: 1.1.29 Start: lock buildroot INFO: installing package(s): /home/kashyap/rpmbuild/SPECS/python-testrepository/results/python-testrepository-0.0.15-1.fc18.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-18-x86_64/root/', 'install', '/home/kashyap/rpmbuild/SPECS/python-testrepository/results/python-testrepository-0.0.15-1.fc18.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: python-testrepository-0.0.15-1.fc18.noarch (/python-testrepository-0.0.15-1.fc18.noarch) Requires: python-subunit You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: python-testrepository-0.0.15-1.fc18.noarch.rpm python-testrepository.noarch: W: spelling-error %description -l en_US workflows -> work flows, work-flows, workloads python-testrepository.noarch: W: spelling-error %description -l en_US subunit -> sub unit, sub-unit, suburbanite python-testrepository.noarch: W: spelling-error %description -l en_US pyunit -> impunity python-testrepository.noarch: W: no-manual-page-for-binary testr 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python-testrepository (rpmlib, GLIBC filtered): /usr/bin/python python(abi) python-fixtures python-subunit python-testtools Provides -------- python-testrepository: python-testrepository MD5-sum check ------------- http://pypi.python.org/packages/source/t/testrepository/testrepository-0.0.15.tar.gz : CHECKSUM(SHA256) this package : a6e7347077bd412915de1f89c5411b85da96abe07f43cd47939dc6f9e0228d94 CHECKSUM(SHA256) upstream package : a6e7347077bd412915de1f89c5411b85da96abe07f43cd47939dc6f9e0228d94 Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review --rpm-spec -n ../SRPMS/python-testrepository-0.0.15-1.fc18.src.rpm
Spec URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository.spec SRPM URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository-0.0.15-2.fc18.src.rpm Description: Provides a database of test results which can be used to support easy developer workflows, supporting functionality like isolating failing tests. Testrepository is compatible with any test suite that can output subunit. This includes any TAP test suite and any pyunit compatible test suite. Fedora Account System Username: pbrady
Note the python-subunit install dependency failure is expected as python-subunit is in review also at present (see blocking bug)
I noticed (& Matthais Runge pointed out too), that %check section is missing ? ---------- %check %{__python} setup.py test ---------- I added the above to the SPEC file: Ran a local build, successfully: ---------- $ rpmbuild -ba python-testrepository.spec . . . Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.prg8hv + umask 022 + cd /home/kashyap/rpmbuild/BUILD + cd testrepository-0.0.15 + /usr/bin/python setup.py test running test Checking .pth file support in . /usr/bin/python -E -c pass Searching for testtools>=0.9.30 Reading http://pypi.python.org/simple/testtools/ Reading https://github.com/testing-cabal/testtools Reading https://launchpad.net/testtools Best match: testtools 0.9.31 Downloading https://launchpad.net/testtools/trunk/0.9.31/+download/testtools-0.9.31.tar.gz Processing testtools-0.9.31.tar.gz Writing /tmp/easy_install-eiAhla/testtools-0.9.31/setup.cfg Running testtools-0.9.31/setup.py -q bdist_egg --dist-dir /tmp/easy_install-eiAhla/testtools-0.9.31/egg-dist-tmp-6gzTiw no previously-included directories found matching 'doc/_build' . . . Installed /home/kashyap/rpmbuild/BUILD/testrepository-0.0.15/python_subunit-0.0.12-py2.7.egg Searching for fixtures Reading http://pypi.python.org/simple/fixtures/ Reading https://launchpad.net/python-fixtures Best match: fixtures 0.3.12 Downloading https://launchpad.net/python-fixtures/trunk/0.3.12/+download/fixtures-0.3.12.tar.gz Processing fixtures-0.3.12.tar.gz Writing /tmp/easy_install-rPxXL4/fixtures-0.3.12/setup.cfg Running fixtures-0.3.12/setup.py -q bdist_egg --dist-dir /tmp/easy_install-rPxXL4/fixtures-0.3.12/egg-dist-tmp-QqVbQK zip_safe flag not set; analyzing archive contents... fixtures._fixtures.packagepath: module references __path__ fixtures.tests._fixtures.test_packagepath: module references __path__ . . . . Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.xAn26W + umask 022 + cd /home/kashyap/rpmbuild/BUILD + cd testrepository-0.0.15 + DOCDIR=/home/kashyap/rpmbuild/BUILDROOT/python-testrepository-0.0.15-2.fc18.x86_64/usr/share/doc/python-testrepository-0.0.15 + export DOCDIR + /usr/bin/mkdir -p /home/kashyap/rpmbuild/BUILDROOT/python-testrepository-0.0.15-2.fc18.x86_64/usr/share/doc/python-testrepository-0.0.15 + cp -pr README.txt Apache-2.0 /home/kashyap/rpmbuild/BUILDROOT/python-testrepository-0.0.15-2.fc18.x86_64/usr/share/doc/python-testrepository-0.0.15 + exit 0 Provides: python-testrepository = 0.0.15-2.fc18 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHave Prefix) <= 4.0-1 Requires: /usr/bin/python python(abi) = 2.7 Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/kashyap/rpmbuild/BUILDROOT/python-testrepository-0.0.15-2.fc18.x86_64 Wrote: /home/kashyap/rpmbuild/SRPMS/python-testrepository-0.0.15-2.fc18.src.rpm Wrote: /home/kashyap/rpmbuild/RPMS/noarch/python-testrepository-0.0.15-2.fc18.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.nmtpI9 + umask 022 + cd /home/kashyap/rpmbuild/BUILD + cd testrepository-0.0.15 + /usr/bin/rm -rf /home/kashyap/rpmbuild/BUILDROOT/python-testrepository-0.0.15-2.fc18.x86_64 + exit 0 ----------
Spec URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository.spec SRPM URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository-0.0.15-3.fc18.src.rpm Description: Provides a database of test results which can be used to support easy developer workflows, supporting functionality like isolating failing tests. Testrepository is compatible with any test suite that can output subunit. This includes any TAP test suite and any pyunit compatible test suite. Fedora Account System Username: pbrady
Spec URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository.spec SRPM URL: http://fedorapeople.org/~pbrady/grizzly-test-rpms/python-testrepository-0.0.15-4.fc18.src.rpm Description: Provides a database of test results which can be used to support easy developer workflows, supporting functionality like isolating failing tests. Testrepository is compatible with any test suite that can output subunit. This includes any TAP test suite and any pyunit compatible test suite. Fedora Account System Username: pbrady
Manual Review: -------------- Short ~~~~~ - Looks good. - TODO: Once 'python-subunit' package is ready, I can do a koji scratch build. Long: ~~~~~ Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. -------- %files %doc README.txt Apache-2.0 %{_bindir}/testr %{python_sitelib}/%{pypi_name} %{python_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info -------- [-]: Package uses nothing in %doc for runtime. [-]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 68 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS/python- testrepository/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [-]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. - We don't rely on Python Eggs, so the above is not applicable. Discussed this with Pádraig. [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. As usual, if something is missing, feel free to point it out.
subunit is now in place
Scratch Build successful: ------------------------- $ koji build --scratch rawhide python-testrepository-0.0.15-4.fc18.src.rpm Uploading srpm: python-testrepository-0.0.15-4.fc18.src.rpm [====================================] 100% 00:00:08 84.99 KiB 9.62 KiB/sec Created task: 5468468 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5468468 Watching tasks (this may be safely interrupted)... 5468468 build (rawhide, python-testrepository-0.0.15-4.fc18.src.rpm): open (buildvm-12.phx2.fedoraproject.org) 5468469 buildArch (python-testrepository-0.0.15-4.fc18.src.rpm, noarch): open (buildvm-05.phx2.fedoraproject.org) 5468469 buildArch (python-testrepository-0.0.15-4.fc18.src.rpm, noarch): open (buildvm-05.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 5468468 build (rawhide, python-testrepository-0.0.15-4.fc18.src.rpm): open (buildvm-12.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 5468468 build (rawhide, python-testrepository-0.0.15-4.fc18.src.rpm) completed successfully Looks good to me. Approved.
New Package SCM Request ======================= Package Name: python-testrepository Short Description: A repository of test results Owners: pbrady mrunge Branches: f18 f19 el6
Git done (by process-git-requests).
python-testrepository-0.0.15-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-testrepository-0.0.15-4.fc18
python-testrepository-0.0.15-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-testrepository-0.0.15-4.fc19
python-testrepository-0.0.15-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-testrepository-0.0.15-4.el6
python-testrepository-0.0.15-4.fc19 has been pushed to the Fedora 19 testing repository.
python-testrepository-0.0.15-4.fc18 has been pushed to the Fedora 18 stable repository.
python-testrepository-0.0.15-4.fc19 has been pushed to the Fedora 19 stable repository.
python-testrepository-0.0.15-4.el6 has been pushed to the Fedora EPEL 6 stable repository.
Package Change Request ====================== Package Name: python-testrepository New Branches: epel7 Owners: pbrady apevec