Bug 913371 - [maven pull] skeleton translation should not be created when -Dzanata.createSkeletons=false
Summary: [maven pull] skeleton translation should not be created when -Dzanata.createS...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Zanata
Classification: Retired
Component: Component-Maven
Version: development
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
: ---
Assignee: zanata-dev-internal
QA Contact: Zanata-QA Mailling List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-21 05:35 UTC by Patrick Huang
Modified: 2015-07-31 01:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-07-31 01:25:12 UTC
Embargoed:


Attachments (Terms of Use)

Description Patrick Huang 2013-02-21 05:35:47 UTC
Filed from caserun https://tcms.engineering.redhat.com/run/57402/#caserun_2159489

Version-Release number of selected component (if applicable):
zanata-2.2

Steps to Reproduce: 
Setup test data as described in

https://engineering.redhat.com/trac/zanata/wiki/
ExampleSettingsAndDocumentProjects#AboutFedora

maven is installed.

Project "AboutFedora" is created, and version "master" is created.

User "autoprjmant is created, joined ja and zh-Hans language team, and set as
project maintainer of About Fedora.

"prjmant mvn push podir" is executed.

 


In command line:

 1. mkdir -p /tmp/zmvn/AboutFedora/pot
 2. mvn zanata:pull -Dzanata.userConfig=zanata.prjmant.ini -Dzanata.transDir=/
    tmp/zmvn/AboutFedora/ -DdryRun
 3. mvn zanata:pull -Dzanata.userConfig=zanata.prjmant.ini -Dzanata.transDir=/
    tmp/zmvn/AboutFedora/ -Dzanata.createSkeletons=false


Actual results: 
after step 3, untranslated files are written to disk even if zanata.createSkeletons set to false.

Expected results:
After Step 2: Nothing should be changed

After Step 3: ls ja-JP and ls -l /tmp/zmvn/AboutFedora/ja-JP should produce
almost identical files, except "Revision_History.po" should not exists in /tmp/
zmvn/AboutFedora/ja-JP. And translation of between "About_Fedora.po" should be
consistant.

Comment 1 Ding-Yi Chen 2013-04-26 05:08:09 UTC
Step to reproduce:

1. Visit a document that has translation.
2. Clear all the translations
3. Pull with maven client:
mvn zanata:pull  -Dzanata.createSkeletons=false

Actual results:
That document is still downloaded, yet the tranlation is empty.

Expected results:
No empty document should be downloaded.

Comment 2 Ding-Yi Chen 2013-04-26 05:35:18 UTC
FYI, it is a podir project.

Comment 3 Sean Flanigan 2013-04-26 05:43:23 UTC
This is happening because the translations have been entered, then cleared.  The server returns a 404 if there are *no* translations, but in this case it returns a result with *empty* translations, and the client treats 404 differently from empty translations.

The client needs to handle empty translations differently, but we should also *consider* not having the server return 404 just because there are no translations yet (assuming the project/version/document/locale are all valid).

Comment 4 Ding-Yi Chen 2014-03-18 05:26:09 UTC
Bug is confirmed with:
[INFO] client API version: 3.2.0, server API version: 3.3.0
[WARNING] client API version is 3.2.0, but server API version is 3.3.0

Comment 5 Zanata Migrator 2015-07-31 01:25:12 UTC
Migrated; check JIRA for bug status: http://zanata.atlassian.net/browse/ZNTA-493


Note You need to log in before you can comment on or make changes to this bug.