Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 915068

Summary: vdsm: 'ValueError: field and value cannot include = character' when removing disks
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: vdsmAssignee: Eduardo Warszawski <ewarszaw>
Status: CLOSED ERRATA QA Contact: Dafna Ron <dron>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.1.3CC: abaron, bazulay, ewarszaw, hateya, iheim, lpeer, scohen, ykaul
Target Milestone: ---Keywords: Regression
Target Release: 3.2.0Flags: abaron: Triaged+
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: vdsm-4.10.2-14.0.el6ev Doc Type: Bug Fix
Doc Text:
--no tech note required
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-10 20:41:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
log
none
logs none

Description Dafna Ron 2013-02-24 15:01:50 UTC
Created attachment 702030 [details]
log

Description of problem:

when I removed a large number of wipe=true disks in iscasi domain I see a lot of WARN's in the log for ValueError: field and value cannot include = character

Version-Release number of selected component (if applicable):

si27.2

How reproducible:

100%

Steps to Reproduce:
1. create a vm with wipe=true -> create a template from the vm -> create a pool of 60 vms
2. remove the vm's
3.
  
Actual results:

we see a lot of WARN's in the log with 'ValueError: field and value cannot include = character'

Expected results:

either fix the code so we only see this when needed or if this is not importent, change the logger to debug

Additional info:log

Comment 1 Dafna Ron 2013-03-17 15:26:07 UTC
moving this to urgent because I ran the same scnario in 3.2 and it seems that lvs are not removed (and they are wipe=true)
engine btw is reporting that the images were deleted. 

05e2d745-65ad-41f2-8f94-dd912dec7fd8 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  078e381a-18ca-4bd4-9073-c523d800df99 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  0c0e13e1-92b5-4d14-8413-527cd7e53b01 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  11db724f-22fa-4816-b658-5fb5df2a2902 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  1ab3ba83-ae86-451a-b6f6-e4ca260ad326 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  1af782af-ae94-4c9e-a4bf-6bf8ed760e30 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  1c9c6b36-8dc8-47f0-b297-a30d0db53606 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  1cff46e9-23d5-4a7e-b7bf-6f007d7e9943 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  255b4f6a-13f6-4f1e-bd09-80a769647b6e a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  26b11c14-9781-44c8-84dd-de5e80c79af5 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  2a001a2b-cea4-42ac-8d9c-aa35f0a8ab34 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  2ae51ec5-3cb3-48c6-a5fd-740f7b1a4916 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  3313f793-a896-40f7-adb4-e13a484bf023 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  38c1f7db-d242-429e-870d-d496c783f519 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  3a1dd4a1-86ee-439e-b53e-7720cdc8fa2d a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  3ea53332-5325-48fe-acb6-da61af1b1565 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  437b0827-256b-4572-b3fa-78de78d722fa a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  44ae8acb-d6c2-4982-9db4-a7f2d79bf984 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  4dfd96b7-3f0f-4cc3-8bef-16873528b425 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  58efd669-f346-45bd-967a-83221c46f13e a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  5afbb101-fad7-4103-abdd-578cc991c9f4 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  5c967cb2-4a96-4c13-8a60-2e87cbaa45fb a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  716caa60-4be1-469b-af21-1f50cbf73a49 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  7b17bdd8-338a-4b15-b44d-e769d8d9a1a2 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  7dac5dce-4701-4252-b83a-fe91b12bd66d a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  7f5b1321-358e-4edb-9b01-5654017e5803 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  8edf420b-69bf-424e-b6b3-5249fcf73d72 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  97ea24f1-bc8d-4045-9526-ce5b9a8dce30 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  995d90ce-4d64-4602-9ed4-88ab90a5fd8c a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  99e8949c-102e-43c3-8130-d299fd9ebf83 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  9fecf474-9342-4894-94c7-9603a4275796 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  ae70019a-837f-4f75-8d05-d15d38406255 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  b6d27f4b-d5b6-4329-abb0-d6d69fcbb807 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  b712e869-3668-4cd9-b209-d38f4fc7a80b a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi-a----   1.00g                                             
  bd91fa58-ba98-4597-9878-39eefd9fbfa5 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  bfae6107-5ab8-4375-9cf9-5de495c82896 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  c6916bbc-ba53-4bf8-956e-eb046ba334c5 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  d8d22abe-c9fc-4c62-b0f4-a303389ab172 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  ddc8faa9-8d87-4071-b7bc-9879916d2e73 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  e2e2814b-7b04-4fb8-8ed4-c1d171bae511 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  e7ff7bf6-22af-461f-b233-e1377e21f2c4 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  f0e0e76c-0a0b-4736-aee8-d9ccbe0a7606 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  f42015db-14b2-4758-a286-d464ea477845 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  f4d897c6-d746-4ea9-b77e-8b130c0f0f16 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                             
  f65d06ff-5baf-4c49-b078-d9f0b0015a59 a9ebf0f9-b784-4d6f-837f-f2580a58841d -wi------   1.00g                                

engine=# SELECT * from images;
              image_guid              |     creation_date      |    size     |               it_guid                |               parentid               | imagestatus |      lastmodified      |            vm_snapshot_id            | v
olume_type | volume_format |            image_group_id            |         _create_date          |         _update_date          |               quota_id               | active 
--------------------------------------+------------------------+-------------+--------------------------------------+--------------------------------------+-------------+------------------------+--------------------------------------+--
-----------+---------------+--------------------------------------+-------------------------------+-------------------------------+--------------------------------------+--------
 00000000-0000-0000-0000-000000000000 | 2008-04-01 00:00:00+03 | 85899345920 | 00000000-0000-0000-0000-000000000000 |                                      |           0 |                        |                                      |  
         2 |             4 |                                      | 2013-02-26 04:56:09.820466+02 |                               |                                      | t
 469f2c84-d777-404e-81c8-9590ae8a2a73 | 2013-03-13 14:56:22+02 |  1073741824 | 00000000-0000-0000-0000-000000000000 | 00000000-0000-0000-0000-000000000000 |           1 | 2013-03-13 14:56:22+02 | 93af1a3c-2cf3-4378-98dc-1ce6296b5dc4 |  
         2 |             5 | f570d5c1-8a96-4c52-be3e-9f556466e9ef | 2013-03-13 14:55:40.419528+02 | 2013-03-13 14:55:43.582814+02 | 00000000-0000-0000-0000-000000000000 | t
 38c1f7db-d242-429e-870d-d496c783f519 | 2013-03-17 11:43:00+02 |  1073741824 | 00000000-0000-0000-0000-000000000000 | 00000000-0000-0000-0000-000000000000 |           1 | 2013-03-17 11:43:02+02 | 726009af-f2b4-4a1e-8923-31ae15232d35 |  
         1 |             5 | 27a74d53-3ac4-4215-9554-ed684e380780 | 2013-03-17 11:43:06.019254+02 | 2013-03-17 11:49:32.391256+02 | 00000000-0000-0000-0000-000000000000 | t
(3 rows)

Comment 2 Dafna Ron 2013-03-17 15:26:36 UTC
Created attachment 711440 [details]
logs

Comment 3 Ayal Baron 2013-03-17 23:06:55 UTC
This is a regression introduced by: http://gerrit.ovirt.org/12178 (Do not delete the template when zeroing a dependant image)

The offending part is:
-                      sdUUID, imgUUID, volsByImg.keys())
+                      sdUUID, imgUUID, volsByImg)

volsByImg contains the equals character '=' which is not allowed when persisting the task.

Comment 6 Dafna Ron 2013-04-07 12:42:31 UTC
verified on vdsm-4.10.2-14.0.el6ev.x86_64 - no problems in the delete image of wipe=true (except a slight performance issue which does not seem related to this issue).

Comment 9 errata-xmlrpc 2013-06-10 20:41:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0886.html