Bug 915760 - [QA] (6.4.0) Trace stack is too verbose for DEBUG level
Summary: [QA] (6.4.0) Trace stack is too verbose for DEBUG level
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: HornetQ
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: DR1
: EAP 6.4.0
Assignee: Justin Bertram
QA Contact: Martin Svehla
URL:
Whiteboard:
Depends On:
Blocks: 1132168 1132463
TreeView+ depends on / blocked
 
Reported: 2013-02-26 13:07 UTC by Dmytro Pogrebniuk
Modified: 2019-08-19 12:45 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1132463 (view as bug list)
Environment:
Last Closed:
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Dmytro Pogrebniuk 2013-02-26 13:07:46 UTC 
Description of problem:
Trace stack from message like next is too verbose:
HornetQClientLogger.LOGGER.debug(this + "::Adding topology listener " + listener, new Exception("Trace"));

Suggesting trace level for next classes:
org.hornetq.core.server.cluster.ClusterManager
org.hornetq.core.paging.cursor.impl.PageCursorProviderImpl
org.hornetq.core.postoffice.impl.SimpleAddressManager
org.hornetq.core.client.impl.Topology

Another option is to remove trace stack from log message
Comment 1 Clebert Suconic 2013-02-26 19:48:55 UTC 
PR was sent... 


this is as old as hornetq BTW. it's not exclusive of 2.3

However I'm fixing this on 2.3
Comment 3 Miroslav Novak 2013-03-19 13:58:07 UTC 
Verified in EAP 6.1.0.ER2.
Comment 4 Miroslav Novak 2013-03-20 14:26:41 UTC 
Accidentally put verified here. Returning to on_qa.
Comment 5 Dmytro Pogrebniuk 2013-04-16 13:25:50 UTC 
ClusterManager.java:813-817

if (HornetQServerLogger.LOGGER.isDebugEnabled())
      {
         HornetQServerLogger.LOGGER.debug("ClusterConnection.start at " + clusterConnection, new Exception("trace"));
      }
Comment 6 Clebert Suconic 2013-04-16 13:46:59 UTC 
I missed that one.. just sent a PR:

https://github.com/hornetq/hornetq/pull/997
Comment 8 Martin Svehla 2013-12-05 13:10:37 UTC 
There are still couple left (checked in 2.3.x branch):

Topology.java:159-160
ClusterConnectionBridge.java:139-144
ClusterConnectionBridge.java:295
ClusterConnectionImpl.java:809-812
Comment 9 Justin Bertram 2014-07-22 17:22:59 UTC 
This was fixed on the 2.3.x branch of HornetQ via commit 32e155a7110d0caa78b9359384fe7bfe758a737e.
Comment 10 Kabir Khan 2014-08-24 11:01:23 UTC 
Appears to be fixed by HQ upgrade to 2.3.21 https://bugzilla.redhat.com/show_bug.cgi?id=1132168. Setting to MODIFIED.
Comment 11 Martin Svehla 2014-09-17 12:42:05 UTC 
Verified in EAP 6.4.0.DR1.1
Note You need to log in before you can comment on or make changes to this bug.