RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 915769 - coroparse: Read unitialized memory if config file contains service without name
Summary: coroparse: Read unitialized memory if config file contains service without name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: corosync
Version: 6.4
Hardware: All
OS: All
low
low
Target Milestone: rc
: ---
Assignee: Jan Friesse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-26 13:30 UTC by Jan Friesse
Modified: 2013-11-21 04:32 UTC (History)
4 users (show)

Fixed In Version: corosync-1.4.1-16.el6
Doc Type: Bug Fix
Doc Text:
Cause: Start corosync with config file where service subsection doesn't contain name key. Consequence: Segfault or refuse to load service with "random garbage" name (access to unitialized memory) Fix: Properly check if name key exists. Result: Corosync will display error and exits properly.
Clone Of:
Environment:
Last Closed: 2013-11-21 04:32:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Proposed patch (3.46 KB, patch)
2013-02-26 13:30 UTC, Jan Friesse
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:1531 0 normal SHIPPED_LIVE corosync bug fix and enhancement update 2013-11-21 00:40:57 UTC

Description Jan Friesse 2013-02-26 13:30:44 UTC
Created attachment 702869 [details]
Proposed patch

Description of problem:
SSIA

Version-Release number of selected component (if applicable):
Flatiron

How reproducible:
100%

Steps to Reproduce:
1. Add following to config file:

service {
    ver: 1
}

2. Start corosync
  
Actual results:
Corosync will ether receive segfault or displays something like "Loading service GARBAGE" where GARBAGE is result of unitialized memory (so random value)

Expected results:
Corosync will properly check given condition and displays error.

Additional info:

"Unit" test:

https://github.com/jfriesse/csts/commit/47e51465ece64dd49d2d2648e7bc3cffc14889c8

Before patch result:
$? != 0

After patch result:
$? == 0

Comment 8 Jaroslav Kortus 2013-09-11 16:06:47 UTC
Verified with config-service-without-name.sh:

FAIL on corosync-1.4.1-15.el6.x86_64 (RHEL6.4) (coredump)
PASS on corosync-1.4.1-17.el6.x86_64 (RHEL6.5)
Sep 11 18:05:22 virt-014 corosync[4070]:   [SERV  ] Service section defined in config file without name key
Sep 11 18:05:22 virt-014 corosync[4070]:   [MAIN  ] Corosync Cluster Engine exiting with status 13 at main.c:1501.

Comment 10 errata-xmlrpc 2013-11-21 04:32:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-1531.html


Note You need to log in before you can comment on or make changes to this bug.