Bug 916102
| Summary: | xulrunner can't be rebuild in mock | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Levente Farkas <lfarkas> | ||||
| Component: | xulrunner | Assignee: | Martin Stransky <stransky> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Desktop QE <desktop-qa-list> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 6.4 | CC: | cschalle, jan.kratochvil, tpelka | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-02-27 12:36:55 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Levente Farkas
2013-02-27 10:04:12 UTC
anyway it's a strange comment here: http://www.kdenlive.org/forum/error-building-build-script-unable-build-libvpx since you change yasm to nasm by design which is the opposite recommended above... and this is the comment in libvpx checkin by Jan Kratochvil <jan.kratochvil>: ----------------------------------------- nasm: add configure support yasm has to be preferred as currently nasm produces marginally less efficient code (longer opcodes). Filed for nasm as: https://sourceforge.net/tracker/?func=detail&atid=106208&aid=3037462&group_id=6208 OTOH package should be built always the same, no matter which additional packages are / are not present on the system. As the package should be built with nasm (as yasm may not be available) we should not use yasm even if it is possibly available. nasm >= approx. 2.09 is required for the nasm compilation as the former versions had a section alignment bug. Provide nasm compatibility. No binary change by this patch with yasm on {x86_64,i686}-fedora13-linux-gnu. Few longer opcodes with nasm on {x86_64,i686}-fedora13-linux-gnu have been checked as safe. ----------------------------------------- and rhel6 has only 2.07 nasm... (In reply to comment #3) > nasm >= approx. 2.09 is required for the nasm compilation as the former > versions had a section alignment bug. [...] > and rhel6 has only 2.07 nasm... This problem of nasm-2.07 vs. nasm-2.09 is workarounded in RHEL: xulrunner-nasm-webm.patch -%define SECTION_RODATA section .rodata +%define SECTION_RODATA section .rodata align=16 (In reply to comment #0) > x86/iwalsh_mmx.asm:27: error: invalid combination of opcode and operands It will be some another incorrect use of sizes, some of those are already fixed in RHEL xulrunner-nasm-webm.patch like: - movd mm7, rax + movq mm7, rax yasm is more benevolent in the allowed syntax and as upstream uses yasm they occasionally introduce these nasm breakages. (In reply to comment #4) > (In reply to comment #3) > This problem of nasm-2.07 vs. nasm-2.09 is workarounded in RHEL: > xulrunner-nasm-webm.patch > -%define SECTION_RODATA section .rodata > +%define SECTION_RODATA section .rodata align=16 do you mean the we shouldn't have to add the align=16 in the patch? > (In reply to comment #0) > > x86/iwalsh_mmx.asm:27: error: invalid combination of opcode and operands > > It will be some another incorrect use of sizes, some of those are already > fixed in RHEL xulrunner-nasm-webm.patch like: > - movd mm7, rax > + movq mm7, rax which one? ie. the above is not included in the xulrunner-nasm-webm.patch. do you have a working patch to be able to build libvpx on rhel-6 with nasm? Created attachment 703389 [details] libvpx master nasm compat. (In reply to comment #5) > do you mean the we shouldn't have to add the align=16 in the patch? No, keep it as it is. FYI RHEL xulrunner already takes care of older nasm, this is not a problem. > which one? ie. the above is not included in the xulrunner-nasm-webm.patch. This one is, but that is already there. > do you have a working patch to be able to build libvpx on rhel-6 with nasm? I have a patch to build libvpx master with nasm, attached, going to upstream it. I haven't yet backported it to the RHEL-6 variant of libvpx but I guess you could do that? I guess you build it in some different environment like CenoOS or so because the package build fine on my RHEL6 box with nasm-2.07-7.el6.x86_64 package. opps sorry for this bugreport i'm just swap the patch in rhel-5.9's xulrunner-17.0.3-1 xulrunner-nasm-webm.patch where this patches are missing:-( anyway than it'd be useful to include your other patches to into rhel-6's xulrunner-nasm-webm.patch. Okay. We don't support WebM on rhel-5.9. |