Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 916102

Summary: xulrunner can't be rebuild in mock
Product: Red Hat Enterprise Linux 6 Reporter: Levente Farkas <lfarkas>
Component: xulrunnerAssignee: Martin Stransky <stransky>
Status: CLOSED NOTABUG QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.4CC: cschalle, jan.kratochvil, tpelka
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-27 12:36:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
libvpx master nasm compat. none

Description Levente Farkas 2013-02-27 10:04:12 UTC
xulrunner-17.0.3-1.el6_3 can't be rebuild in mock since it gives this error:
-----------------------------------
nasm -o loopfilter_mmx.o -f elf64 -DPIC -I. -I/builddir/build/BUILD/xulrunner-17.0.3/mozilla-esr17/media/libvpx/ -I/builddir/build/BUILD/xulrunner-17.0.3/moz
illa-esr17/media/libvpx/vpx_ports/  -g  /builddir/build/BUILD/xulrunner-17.0.3/mozilla-esr17/media/libvpx/vp8/common/x86/loopfilter_mmx.asm
/builddir/build/BUILD/xulrunner-17.0.3/mozilla-esr17/media/libvpx/vp8/common/x86/iwalsh_mmx.asm:27: error: invalid combination of opcode and operands
make[5]: *** [iwalsh_mmx.o] Error 1
-----------------------------------

Comment 2 Levente Farkas 2013-02-27 10:20:23 UTC
anyway it's a strange comment here:
http://www.kdenlive.org/forum/error-building-build-script-unable-build-libvpx
since you change yasm to nasm by design which is the opposite recommended above...

Comment 3 Levente Farkas 2013-02-27 10:22:03 UTC
and this is the comment in libvpx checkin by Jan Kratochvil <jan.kratochvil>:
-----------------------------------------
nasm: add configure support

yasm has to be preferred as currently nasm produces marginally less
efficient code (longer opcodes). Filed for nasm as:
https://sourceforge.net/tracker/?func=detail&atid=106208&aid=3037462&group_id=6208

OTOH package should be built always the same, no matter which additional
packages are / are not present on the system. As the package should be
built with nasm (as yasm may not be available) we should not use yasm
even if it is possibly available.

nasm >= approx. 2.09 is required for the nasm compilation as the former
versions had a section alignment bug.

Provide nasm compatibility. No binary change by this patch with yasm on
{x86_64,i686}-fedora13-linux-gnu. Few longer opcodes with nasm on
{x86_64,i686}-fedora13-linux-gnu have been checked as safe.
-----------------------------------------
and rhel6 has only 2.07 nasm...

Comment 4 Jan Kratochvil 2013-02-27 11:40:39 UTC
(In reply to comment #3)
> nasm >= approx. 2.09 is required for the nasm compilation as the former
> versions had a section alignment bug.
[...]
> and rhel6 has only 2.07 nasm...

This problem of nasm-2.07 vs. nasm-2.09 is workarounded in RHEL:
xulrunner-nasm-webm.patch
-%define SECTION_RODATA section .rodata
+%define SECTION_RODATA section .rodata align=16

(In reply to comment #0)
> x86/iwalsh_mmx.asm:27: error: invalid combination of opcode and operands

It will be some another incorrect use of sizes, some of those are already fixed in RHEL xulrunner-nasm-webm.patch like:
-    movd        mm7, rax
+    movq        mm7, rax

yasm is more benevolent in the allowed syntax and as upstream uses yasm they occasionally introduce these nasm breakages.

Comment 5 Levente Farkas 2013-02-27 12:11:28 UTC
(In reply to comment #4)
> (In reply to comment #3)
> This problem of nasm-2.07 vs. nasm-2.09 is workarounded in RHEL:
> xulrunner-nasm-webm.patch
> -%define SECTION_RODATA section .rodata
> +%define SECTION_RODATA section .rodata align=16

do you mean the we shouldn't have to add the align=16 in the patch?

 
> (In reply to comment #0)
> > x86/iwalsh_mmx.asm:27: error: invalid combination of opcode and operands
> 
> It will be some another incorrect use of sizes, some of those are already
> fixed in RHEL xulrunner-nasm-webm.patch like:
> -    movd        mm7, rax
> +    movq        mm7, rax

which one? ie. the above is not included in the xulrunner-nasm-webm.patch.

do you have a working patch to be able to build libvpx on rhel-6 with nasm?

Comment 6 Jan Kratochvil 2013-02-27 12:15:10 UTC
Created attachment 703389 [details]
libvpx master nasm compat.

(In reply to comment #5)
> do you mean the we shouldn't have to add the align=16 in the patch?

No, keep it as it is.  FYI RHEL xulrunner already takes care of older nasm, this is not a problem.


> which one? ie. the above is not included in the xulrunner-nasm-webm.patch.

This one is, but that is already there.


> do you have a working patch to be able to build libvpx on rhel-6 with nasm?

I have a patch to build libvpx master with nasm, attached, going to upstream it.  I haven't yet backported it to the RHEL-6 variant of libvpx but I guess you could do that?

Comment 7 Martin Stransky 2013-02-27 12:32:30 UTC
I guess you build it in some different environment like CenoOS or so because the package build fine on my RHEL6 box with nasm-2.07-7.el6.x86_64 package.

Comment 8 Levente Farkas 2013-02-27 12:33:46 UTC
opps sorry for this bugreport i'm just swap the patch in rhel-5.9's xulrunner-17.0.3-1 xulrunner-nasm-webm.patch where this patches are missing:-(

anyway than it'd be useful to include your other patches to into rhel-6's xulrunner-nasm-webm.patch.

Comment 9 Martin Stransky 2013-02-27 12:36:55 UTC
Okay. We don't support WebM on rhel-5.9.