Bug 916553 (ghc-setenv) - Review Request: ghc-setenv - Cross-platform library for setting environment variables
Summary: Review Request: ghc-setenv - Cross-platform library for setting environment v...
Keywords:
Status: CLOSED ERRATA
Alias: ghc-setenv
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Shakthi Kannan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 916518
TreeView+ depends on / blocked
 
Reported: 2013-02-28 10:11 UTC by Jens Petersen
Modified: 2013-06-29 18:35 UTC (History)
4 users (show)

Fixed In Version: ghc-setenv-0.1.0-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-20 02:31:55 UTC
Type: ---
Embargoed:
shakthimaan: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jens Petersen 2013-02-28 10:11:44 UTC
Spec URL: http://petersen.fedorapeople.org//ghc-setenv.spec
SRPM URL: http://petersen.fedorapeople.org//ghc-setenv-0.1.0-1.fc18.src.rpm

Description:
A cross-platform library for setting environment variables.

Comment 1 Jens Petersen 2013-02-28 10:11:51 UTC
This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=5063722

Comment 2 Shakthi Kannan 2013-06-08 15:15:32 UTC
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[x]: Package does not contain any libtool archives (.la)
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[-]: Static libraries in -static subpackage, if present.
     Note: ghc-setenv-devel-0.1.0-1.fc16.x86_64.rpm :
     /usr/lib64/ghc-7.0.4/setenv-0.1.0/libHSsetenv-0.1.0.a ghc-setenv-
     devel-0.1.0-1.fc16.x86_64.rpm :
     /usr/lib64/ghc-7.0.4/setenv-0.1.0/libHSsetenv-0.1.0_p.a

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
     Note: warning: File listed twice: /usr/share/doc/ghc-setenv-0.1.0
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 81920 bytes in 17 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (setenv-0.1.0.tar.gz)
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.

Rpmlint
-------
Checking: ghc-setenv-0.1.0-1.fc16.src.rpm
          ghc-setenv-devel-0.1.0-1.fc16.x86_64.rpm
          ghc-setenv-0.1.0-1.fc16.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint ghc-setenv ghc-setenv-devel
ghc-setenv.x86_64: I: enchant-dictionary-not-found en_US
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'

Requires
--------
ghc-setenv-devel-0.1.0-1.fc16.x86_64.rpm (rpmlib, GLIBC filtered):
    
    /bin/sh  
    ghc(setenv-0.1.0) = 62c9de487eba614162da9c38aa17011f
    ghc-compiler = 7.0.4
    ghc-devel(base-4.3.1.0) = d2298ea3d0e16f270dfe58dfbda12bff
    ghc-devel(setenv-0.1.0) = 62c9de487eba614162da9c38aa17011f
    ghc-devel(unix-2.4.2.0) = 58b1a2dba5afd4464c2e3918310189ff
    ghc-prof(base-4.3.1.0) = d2298ea3d0e16f270dfe58dfbda12bff
    ghc-prof(unix-2.4.2.0) = 58b1a2dba5afd4464c2e3918310189ff
    ghc-setenv = 0.1.0-1.fc16

ghc-setenv-0.1.0-1.fc16.x86_64.rpm (rpmlib, GLIBC filtered):
    
    ghc(base-4.3.1.0) = d2298ea3d0e16f270dfe58dfbda12bff
    ghc(unix-2.4.2.0) = 58b1a2dba5afd4464c2e3918310189ff
    libHSbase-4.3.1.0-ghc7.0.4.so()(64bit)  
    libHSghc-prim-0.2.0.0-ghc7.0.4.so()(64bit)  
    libHSinteger-gmp-0.2.0.3-ghc7.0.4.so()(64bit)  
    libHSunix-2.4.2.0-ghc7.0.4.so()(64bit)  
    libc.so.6()(64bit)  
    libdl.so.2()(64bit)  
    libgmp.so.3()(64bit)  
    libpthread.so.0()(64bit)  
    librt.so.1()(64bit)  
    libutil.so.1()(64bit)  
    rtld(GNU_HASH)  

Provides
--------
ghc-setenv-devel-0.1.0-1.fc16.x86_64.rpm:
    
    ghc-devel(setenv-0.1.0) = 62c9de487eba614162da9c38aa17011f
    ghc-prof(setenv-0.1.0) = 62c9de487eba614162da9c38aa17011f
    ghc-setenv-devel = 0.1.0-1.fc16
    ghc-setenv-devel(x86-64) = 0.1.0-1.fc16
    ghc-setenv-doc = 0.1.0-1.fc16
    ghc-setenv-prof = 0.1.0-1.fc16

ghc-setenv-0.1.0-1.fc16.x86_64.rpm:
    
    ghc(setenv-0.1.0) = 62c9de487eba614162da9c38aa17011f
    ghc-setenv = 0.1.0-1.fc16
    ghc-setenv(x86-64) = 0.1.0-1.fc16
    libHSsetenv-0.1.0-ghc7.0.4.so()(64bit)  

MD5-sum check
-------------
http://hackage.haskell.org/packages/archive/setenv/0.1.0/setenv-0.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : 5e37d7a0a7abe3830fdb42cbba39f9b707f35a8affa770656645e7e5ee128413
  CHECKSUM(SHA256) upstream package : 5e37d7a0a7abe3830fdb42cbba39f9b707f35a8affa770656645e7e5ee128413

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-16-x86_64
Command line :/usr/bin/fedora-review -b 916553

Successful Koji builds for F17, F18, F19, F20:

http://koji.fedoraproject.org/koji/taskinfo?taskID=5483326
http://koji.fedoraproject.org/koji/taskinfo?taskID=5483327
http://koji.fedoraproject.org/koji/taskinfo?taskID=5483330
http://koji.fedoraproject.org/koji/taskinfo?taskID=5483335

Package APPROVED.

Comment 3 Jens Petersen 2013-06-10 03:42:17 UTC
Thank you very much.


New Package SCM Request
=======================
Package Name: ghc-setenv
Short Description: Cross-platform library for setting environment variables
Owners: petersen
Branches: f17 f18 f19 el6
InitialCC: haskell-sig

Comment 4 Gwyn Ciesla 2013-06-10 11:52:01 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-06-11 01:59:35 UTC
ghc-setenv-0.1.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ghc-setenv-0.1.0-1.fc18

Comment 6 Fedora Update System 2013-06-11 01:59:47 UTC
ghc-setenv-0.1.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/ghc-setenv-0.1.0-1.el6

Comment 7 Fedora Update System 2013-06-11 01:59:57 UTC
ghc-setenv-0.1.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ghc-setenv-0.1.0-1.fc19

Comment 8 Fedora Update System 2013-06-11 02:00:10 UTC
ghc-setenv-0.1.0-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/ghc-setenv-0.1.0-1.fc17

Comment 9 Fedora Update System 2013-06-11 17:32:41 UTC
Package ghc-setenv-0.1.0-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing ghc-setenv-0.1.0-1.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-10416/ghc-setenv-0.1.0-1.el6
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2013-06-20 02:31:55 UTC
ghc-setenv-0.1.0-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2013-06-20 02:34:01 UTC
ghc-setenv-0.1.0-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2013-06-26 19:07:24 UTC
ghc-setenv-0.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2013-06-29 18:35:09 UTC
ghc-setenv-0.1.0-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.