Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 917042

Summary: [TEXT] when task fails but cleanup is successful the exit state of the task is 'cleanSuccess' which is confusing
Product: Red Hat Enterprise Virtualization Manager Reporter: Katarzyna Jachim <kjachim>
Component: vdsmAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: abaron, acathrow, bazulay, derez, hateya, iheim, jkt, lpeer, ncredi, pstehlik, Rhev-m-bugs, scohen, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.3.0Flags: scohen: Triaged+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-21 09:48:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine log
none
vdsm log none

Description Katarzyna Jachim 2013-03-01 14:08:02 UTC
Description of problem:
Probably there should be no exception returned when the task ended with cleanSuccess result.

2013-03-01 14:28:54,542 ERROR [org.ovirt.engine.core.bll.SPMAsyncTask] (QuartzScheduler_Worker-21) BaseAsyncTask::LogEndTaskFailure: Task b4460f6b-1a40-4277-afdf-825911b46a10 (Parent Command AddDisk, Parameters Type org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters) ended with failure:
-- Result: cleanSuccess
-- Message: VDSGenericException: VDSTaskResultNotSuccessException: TaskState contained successful return code, but a non-success result ('cleanSuccess').,
-- Exception: VDSGenericException: VDSTaskResultNotSuccessException: TaskState contained successful return code, but a non-success result ('cleanSuccess').
2013-03-01 14:28:54,543 INFO  [org.ovirt.engine.core.bll.EntityAsyncTask] (QuartzScheduler_Worker-21) EntityAsyncTask::EndActionIfNecessary: All tasks of entity 1a4716ae-3960-478e-84e3-22f14c539280 has ended -> executing EndAction
2013-03-01 14:28:54,544 INFO  [org.ovirt.engine.core.bll.EntityAsyncTask] (QuartzScheduler_Worker-21) EntityAsyncTask::EndAction: Ending action for 1 tasks (entity ID: 1a4716ae-3960-478e-84e3-22f14c539280): calling EndAction for action type AddDisk.
2013-03-01 14:28:54,546 INFO  [org.ovirt.engine.core.bll.EntityAsyncTask] (pool-3-thread-49) EntityAsyncTask::EndCommandAction [within thread] context: Attempting to EndAction AddDisk, executionIndex: 0
2013-03-01 14:28:54,571 ERROR [org.ovirt.engine.core.bll.AddDiskCommand] (pool-3-thread-49) [28d8b577] Ending command with failure: org.ovirt.engine.core.bll.AddDiskCommand
2013-03-01 14:28:54,581 ERROR [org.ovirt.engine.core.bll.AddImageFromScratchCommand] (pool-3-thread-49) [69ac9e71] Ending command with failure: org.ovirt.engine.core.bll.AddImageFromScratchCommand



Version-Release number of selected component (if applicable): SF9


How reproducible: always


Steps to Reproduce:
1. 
2.
3.
  
Actual results:
Exception then task ended with cleanSuccess result.

Expected results:
There should be no exception returned when the task ended with cleanSuccess result.

Additional info:

Comment 1 Katarzyna Jachim 2013-03-01 14:08:33 UTC
Created attachment 704179 [details]
engine log

Comment 2 Katarzyna Jachim 2013-03-01 14:09:15 UTC
Created attachment 704180 [details]
vdsm log

Comment 3 Dafna Ron 2013-03-03 10:44:34 UTC
Dan, can you please see if its the same as: https://bugzilla.redhat.com/show_bug.cgi?id=894035

Comment 4 Daniel Erez 2013-03-03 17:10:29 UTC
(In reply to comment #3)
> Dan, can you please see if its the same as:
> https://bugzilla.redhat.com/show_bug.cgi?id=894035

No, the fix of bug 894035 is specific for live storage migration.
The described scenario here seems correct, 'cleanSuccess' merely means that the rollback has been completed successfully (i.e. the command has ended with an exception which caused a rollback).

Comment 5 Barak 2013-04-07 11:54:50 UTC
What is confusing ?

Comment 6 Haim 2013-04-07 19:17:31 UTC
(In reply to comment #5)
> What is confusing ?

cleanSuccess, what does it mean? how does it imply task failed?