Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/python-listquote.spec SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/python-listquote-1.4.0-1.fc17.src.rpm Description: This module provides functions for turning lists into strings - and back again. It properly handles quoting and unquoting of elements and can even parse recursive lists. Because a CSV (comma separated value) file is basically a list - the module includes functions for easily reading and writing CSVs. Fedora Account System Username: konradm N.B.: This is a blocker for #519652 (SABnzbd+)
RPM lint clean: python-listquote.src: W: invalid-url URL: http://www.voidspace.org.uk/python/listquote.html timed out (^^^ bogus) python-listquote.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Hello Conrad Meyer, The Source0 is invalid URL, please fix it. BuildRequires: python-devel is wrong, is python2-devel or python3-devel. Please, can you create a repository for store the package and do a setup.py? cp %{SOURCE0} . cat >setup.py <<EOS #!/usr/bin/env python from distutils.core import setup setup(name='listquote', version='1.4.0', description='%{summary}', author='Michael Foord', author_email='fuzzyman.uk', url='http://www.voidspace.org.uk/python/listquote.html', py_modules=['listquote'], ) EOS %{python_sitelib}/* is wrong too, you must write the name of the package, example %{python_sitelib}/%{sample}/. And the documentation? Have not documentation? Regards!
(In reply to comment #2) > The Source0 is invalid URL, please fix it. How? There is no direct download link from upstream, and RPM does not accept the download URL. > BuildRequires: python-devel is wrong, is python2-devel or python3-devel. Fixed. > Please, can you create a repository for store the package and do a setup.py? I'm sorry, I don't understand what you're asking. What do you want? There is a setup.py in the spec to help it play nice with the Python package system. > %{python_sitelib}/* is wrong too, you must write the name of the package, > example %{python_sitelib}/%{sample}/. Can you point to the relevant packaging guideline for this? Nothing else should be in the build root in %{python_sitelib}. It could be %{python_sitelib}/listquote* if you want. > And the documentation? Have not documentation? No, unfortunately there is no documentation for this package. It is a very simple single-file "library" from upstream. New spec, SRPM: http://konradm.fedorapeople.org/fedora/SPECS/python-listquote.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-listquote-1.4.0-2.fc18.src.rpm
About the guideline, please check the guideline, because in the fedora review the result is [ ]: Package meets the Packaging Guidelines::Python [0] Remove rm -rf %{buildroot}, after if you want build for EPEL5, write again it, but now remove it please.- >Can you point to the relevant packaging guideline for this? Nothing else should >be in the build root in %{python_sitelib}. It could be >%{python_sitelib}/listquote* if you want. Yes, please. >No, unfortunately there is no documentation for this package. It is a very >simple single-file "library" from upstream. Ok, don't problem. [0] https://fedoraproject.org/wiki/Packaging:Python#Macros
Built successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=5304436 But, review my suggestions.
(In reply to comment #4) > About the guideline, please check the guideline, because in the fedora > review the result is [ ]: Package meets the Packaging Guidelines::Python [0] > > Remove rm -rf %{buildroot}, after if you want build for EPEL5, write again > it, but now remove it please.- Ah, ok. Looks like rpmdev-newspec is fairly out of date =(. > >Can you point to the relevant packaging guideline for this? Nothing else should >be in the build root in %{python_sitelib}. It could be >%{python_sitelib}/listquote* if you want. > > Yes, please. Fixed and fixed =). http://konradm.fedorapeople.org/fedora/SPECS/python-listquote.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-listquote-1.4.0-3.fc18.src.rpm
Review the guideline for SourceURL, you have that do a tarball file with the source. [0] After, remove: rm -rf %{name}-%{version} mkdir %{name}-%{version} cd %{name}-%{version} cp %{SOURCE0} . And add %setup -q -n %{name}-%{version} Too remove cd %{name}-%{version} from %build and %install. When you finished, you let me know for do the formal review. [0] http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
(In reply to comment #7) > Review the guideline for SourceURL, you have that do a tarball file with the > source. [0] Done. > When you finished, you let me know for do the formal review. Ok, go ahead =). http://konradm.fedorapeople.org/fedora/SPECS/python-listquote.spec http://konradm.fedorapeople.org/fedora/SRPMS/python-listquote-1.4.0-4.fc18.src.rpm
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-listquote-1.4.0-4.fc20.noarch.rpm python-listquote.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-listquote python-listquote.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- python-listquote (rpmlib, GLIBC filtered): python(abi) Provides -------- python-listquote: python-listquote --------------------------- Package Approved ---------------------------
Thanks, Yohan! New Package SCM Request ======================= Package Name: python-listquote Short Description: Functions for Lists, Quotes and CSVs Owners: konradm Branches: f19 f18 InitialCC:
Git done (by process-git-requests).
Thanks, Jon! Building in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5313349 Closing the review bug.
python-listquote-1.4.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-listquote-1.4.0-4.fc18
python-listquote-1.4.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-listquote-1.4.0-4.fc19
python-listquote-1.4.0-4.fc19 has been pushed to the Fedora 19 stable repository.
python-listquote-1.4.0-4.fc18 has been pushed to the Fedora 18 stable repository.