Bug 917463 - continued problem with postfix /usr/libexec/postfix/chroot-update
Summary: continued problem with postfix /usr/libexec/postfix/chroot-update
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: postfix
Version: 18
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 959691 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-04 05:33 UTC by John Heidemann
Modified: 2013-06-04 21:06 UTC (History)
3 users (show)

Fixed In Version: postfix-2.9.6-5.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-01 03:26:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description John Heidemann 2013-03-04 05:33:50 UTC
Description of problem:
systemd still has error message for postfix's chroot-update,
sort of like bug 832742


Version-Release number of selected component (if applicable):
postfix-2.9.6-1.fc18.x86_64
systemd-197-1.fc18.2.x86_64


How reproducible:
every time

Steps to Reproduce:
1. start with postfix
2. systemctl restart postfix.service
3.systemctl status postfix.service
  
Actual results:

	 Process: 7822 ExecStartPre=/usr/libexec/postfix/chroot-update (code=exited, status=1/FAILURE)



Expected results:

no failure messages

Additional info:

The problem is (I think) that systemd wants each program to exit with status 0,
but /usr/libexec/postfix/chroot-update 
exits with status one if no /etc/postfix/chroot-update
exists

Suggested fix:
add "exit 0" to the end of /usr/libexec/postfix/chroot-update

with this addition, the ugly red text goes away:
	 Process: 8062 ExecStartPre=/usr/libexec/postfix/chroot-update (code=exited, status=0/SUCCESS)


Patch:
--- chroot-update-	2013-03-03 21:33:31.271219600 -0800
+++ chroot-update	2013-03-03 21:32:54.040981528 -0800
@@ -1,3 +1,4 @@
 #!/bin/bash
 
 [ -x /etc/postfix/chroot-update ] && exec /etc/postfix/chroot-update
+exit 0

Comment 1 Michael S. 2013-05-22 07:50:06 UTC
*** Bug 959691 has been marked as a duplicate of this bug. ***

Comment 2 Michael S. 2013-05-22 07:54:25 UTC
exit 0 would mask any issue in /etc/postfix/chroot-update

Comment 3 Sjoerd Mullender 2013-05-22 12:50:14 UTC
(In reply to Michael Scherer from comment #2)
> exit 0 would mask any issue in /etc/postfix/chroot-update

No it wouldn't.  /etc/posfix/chroot-update would be exec'ed, which means that the shell doing it would be gone and not reach the next line to execute the exit 0.

Comment 4 John Heidemann 2013-05-22 20:23:02 UTC
Sjoerd's comment #3 is correct, the patch proposed in the bug report will not affect problems in chroot-update.

Is there any chance of getting this one-line fix in?

Comment 5 Jaroslav Škarvada 2013-05-23 10:35:50 UTC
Thanks, accepted.

Comment 6 Fedora Update System 2013-05-23 12:08:28 UTC
postfix-2.10.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/postfix-2.10.0-2.fc19

Comment 7 Fedora Update System 2013-05-23 12:10:59 UTC
postfix-2.9.6-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/postfix-2.9.6-5.fc18

Comment 8 Fedora Update System 2013-05-23 20:01:58 UTC
Package postfix-2.10.0-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing postfix-2.10.0-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-9033/postfix-2.10.0-2.fc19
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2013-06-01 03:26:12 UTC
postfix-2.10.0-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2013-06-04 21:06:44 UTC
postfix-2.9.6-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.