Description of problem: Coming to create a VM the ISO domain was empty - no VFD no tools For VFD I found in the installation log: 2013-03-07 18:52:04::ERROR::rhevm-setup::1790::root:: Traceback (most recent call last): File "/usr/bin/rhevm-setup", line 1787, in _loadFilesToIsoDomain utils.copyFile(filename, targetPath, basedefs.CONST_VDSM_UID, basedefs.CONST_KVM_GID) File "/usr/share/ovirt-engine/scripts/common_utils.py", line 706, in copyFile shutil.copy2(fileSrc, destination) File "/usr/lib64/python2.6/shutil.py", line 95, in copy2 copyfile(src, dst) File "/usr/lib64/python2.6/shutil.py", line 50, in copyfile with open(src, 'rb') as fsrc: IOError: [Errno 2] No such file or directory: '/usr/share/virtio-win/virtio-win.vfd' [root@rhevm32 yum.repos.d]# rpm -ql virtio-win-1.6.3-3.el6.noarch | grep vfd /usr/share/virtio-win/virtio-win-1.6.3_amd64.vfd /usr/share/virtio-win/virtio-win-1.6.3_x86.vfd /usr/share/virtio-win/virtio-win_amd64.vfd /usr/share/virtio-win/virtio-win_x86.vfd I could not find the guest tools iso but the file is there, so it looks like this failure prevented farther attempts to copy Version-Release number of selected component (if applicable): SF9 How reproducible: Always Steps to Reproduce: 1. Install RHEVM on a clean 6.4 machine 2. Select the option to create local ISO Actual results: ISO domain is not populated with any file Expected results: ISO domain to contain all virtio drivers files and the rhev-guest-tools If one of these can't be found the script should still try the others. Additional info: > Yes, the addition of SCSI drivers made the complete collection of > drivers larger than what we could fit on a VFD, so we split them into > two VFDs by architecture (32 vs. 64 bit). > > - Jay
From Moran: "ok so two issues here: -needs rpm dependency >= virtio-win-1.6.3-3 -installer/upgrade should pull the new files from the right places to the iso domain." I would add that copy error should be caught per file so next time it will get to copy the ISO, but this could be done in a different BZ
Juan Hernandez suggested to add to iso domain any .iso and any .vfd found in /usr/share/virio-win. This will lead to having both versioned and unversioned iso and vfd inside the iso domain. Is the duplication an issue?
patch merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=5291ac720b7b9353a3ea42ff78e7dd53dc6e4af6
(In reply to comment #2) > I would add that copy error should be caught per file so next time it will > get to copy the ISO, but this could be done in a different BZ On downstream I'll push also the patch used for solving bug #904763 that avoid the copy error by checking if the file doesn't exists.
(In reply to comment #2) > -needs rpm dependency >= virtio-win-1.6.3-3 The submitted patches are compatible with virtio-win >= 1.6.3 but also with < 1.6.3. If there isn't other reasons for updating the dependency on virtio-win it isn't needed.
I have been talking about this bug and the patch with Sandro, and reading comment #2 it is not clear for me if we want to add "Requires: virtio-win >= 1.6.3". Simon, do we want to add the requirement? For new installs is not that relevant as the latest virtio-win package will be installed anyhow. The only relevant situation is when installing RHEV-M in a machine with and old virtio-win package already installed, as in that case nothing will be copied to the ISO domain. I am in favor of adding the dependency. It isn't clear for me either if we want to take care of this issue during upgrade. Currently we don't do anything with the ISO domain during upgrade, but it is possible (maybe a bit difficult) to check the ISO domain and copy the files during the upgrade if they aren't there. Do we want to do this as well?
(In reply to comment #8) > I have been talking about this bug and the patch with Sandro, and reading > comment #2 it is not clear for me if we want to add "Requires: virtio-win >= > 1.6.3". Simon, do we want to add the requirement? For new installs is not > that relevant as the latest virtio-win package will be installed anyhow. The > only relevant situation is when installing RHEV-M in a machine with and old > virtio-win package already installed, as in that case nothing will be copied > to the ISO domain. I am in favor of adding the dependency. Then please add, I think there is already a bug requesting that these to be updated while updating RHEV Manager > > It isn't clear for me either if we want to take care of this issue during > upgrade. Currently we don't do anything with the ISO domain during upgrade, > but it is possible (maybe a bit difficult) to check the ISO domain and copy > the files during the upgrade if they aren't there. Do we want to do this as > well? I've asked for is long ago, can't find the BZ ATM so I may not have opened one. Same goes for rhev-tools which are updated but not copied to the ISO directory. The question is do we want to do it now, or in a separate BZ
In my opinion adding the "Requires: ..." should go in this BZ and in this patch. The upgrade issue may be more complicated, so I would suggest to do it in a different BZ.
I'll add the Requires update in the downstream patch. For the upgrade issue, I agree with Juan, it should be done in a different BZ.
Verified on sf-13: Found ISO domain populated with: RHEV-toolsSetup_3.2_3.iso CD/DVD virtio-win-1.6.3.iso CD/DVD virtio-win-1.6.3_amd64.vfd Floppy virtio-win-1.6.3_x86.vfd Floppy
3.2 has been released