Spec URL: http://smani.fedorapeople.org/gtkspellmm30.spec SRPM URL: http://smani.fedorapeople.org/gtkspellmm30-3.0.0-1.fc19.src.rpm Description: On-the-fly spell checking for GtkTextView widgets - C++ bindings Fedora Account System Username: smani
Problems: 1. Both tarball and spec claim that the package's license is GPLv2+, but the code appear to be LGPLv2.1+ . 2. The -devel subpackage should depend on base package of the same arch. I.e., %{name}{%?_isa} = %{version}-%{release} . 3. The -doc subpackage should not depend on base package (at least i suppose you don't need the library to read the documentation). Note that you have to add COPYING to it after removing the dependency. 4. Explicit requires in -devel subpackage are not necessary (except on the base package). rpmbuild will generate them. 5. %defattr is not necessary.
Spec URL: http://smani.fedorapeople.org/gtkspellmm30.spec SRPM URL: http://smani.fedorapeople.org/gtkspellmm30-3.0.1-1.fc20.src.rpm * Fri Apr 26 2013 Sandro Mani <manisandro> - 3.0.1-1 - New upstream release (uses correct GPLv2 license headers) All noted problems are fixed. A note on the -doc dependency: this seems to rather arbitrary, looking at other packages. Perhaps one should mention it on fedora-devel and have a note added to the packaging guidelines, whether or not the base package should be a dependency? Anyway, thanks!
Nitpick: The dependency on pkgconfig in -devel is not necessary either. rpmbuild will generate it, because the subpackage contains a .pc file (and therefore provides pkgconfig(gtkspellmm-3.0)).
Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Spec file lacks Packager, Vendor, PreReq tags. Note: Found : Packager: David Tardon <dtardon> See: (this test has no URL) ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package requires other packages for directories it uses. [ ]: Package uses nothing in %doc for runtime. [ ]: Package is not known to require ExcludeArch. [ ]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gtkspellmm30-doc [ ]: Package complies to the Packaging Guidelines [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/dtardon/work/rpm/919260-gtkspellmm30/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package consistently uses macro is (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Package must own all directories that it creates. [ ]: Package does not own files or directories owned by other packages. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 5 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gtkspellmm30-3.0.1-1.fc18.x86_64.rpm gtkspellmm30-devel-3.0.1-1.fc18.x86_64.rpm gtkspellmm30-doc-3.0.1-1.fc18.noarch.rpm gtkspellmm30-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gtkspellmm30-devel gtkspellmm30-doc gtkspellmm30 gtkspellmm30-devel.x86_64: W: no-documentation gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libatkmm-1.6.so.1 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libgdkmm-3.0.so.1 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libgiomm-2.4.so.1 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libpangomm-1.4.so.1 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libgtk-3.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libcairomm-1.0.so.1 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libgdk-3.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libatk-1.0.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libgio-2.0.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libpangocairo-1.0.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libgdk_pixbuf-2.0.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libcairo-gobject.so.2 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libpango-1.0.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libcairo.so.2 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libglib-2.0.so.0 gtkspellmm30.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkspellmm-3.0.so.0.0.0 /lib64/libm.so.6 3 packages and 0 specfiles checked; 0 errors, 17 warnings. # echo 'rpmlint-done:' Requires -------- gtkspellmm30-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gtkspellmm30(x86-64) libgtkspellmm-3.0.so.0()(64bit) pkgconfig pkgconfig(glibmm-2.4) pkgconfig(gtk+-3.0) pkgconfig(gtkmm-3.0) pkgconfig(gtkspell3-3.0) gtkspellmm30-doc (rpmlib, GLIBC filtered): gtkmm30-doc gtkspellmm30 (rpmlib, GLIBC filtered): /sbin/ldconfig libatk-1.0.so.0()(64bit) libatkmm-1.6.so.1()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libcairomm-1.0.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgdkmm-3.0.so.1()(64bit) libgio-2.0.so.0()(64bit) libgiomm-2.4.so.1()(64bit) libglib-2.0.so.0()(64bit) libglibmm-2.4.so.1()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtkmm-3.0.so.1()(64bit) libgtkspell3-3.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangomm-1.4.so.1()(64bit) libsigc-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- gtkspellmm30-devel: gtkspellmm30-devel gtkspellmm30-devel(x86-64) pkgconfig(gtkspellmm-3.0) gtkspellmm30-doc: gtkspellmm30-doc gtkspellmm30: gtkspellmm30 gtkspellmm30(x86-64) libgtkspellmm-3.0.so.0()(64bit) MD5-sum check ------------- http://sourceforge.net/projects/gtkspell/files/gtkspellmm/gtkspellmm-3.0.1.tar.gz : CHECKSUM(SHA256) this package : 61d98f85a1a4b923f4fd7de465e0b7518cf1c630e7af0912b53723e28a511d8b CHECKSUM(SHA256) upstream package : 61d98f85a1a4b923f4fd7de465e0b7518cf1c630e7af0912b53723e28a511d8b Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -b 919260
New Package SCM Request ======================= Package Name: gtkspellmm30 Short On-the-fly spell checking for GtkTextView widgets - C++ bindings Owners: smani Branches: f18 f19
Git done (by process-git-requests).
gtkspellmm30-3.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gtkspellmm30-3.0.1-1.fc19
gtkspellmm30-3.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gtkspellmm30-3.0.1-1.fc18
gtkspellmm30-3.0.1-1.fc18 has been pushed to the Fedora 18 testing repository.
gtkspellmm30-3.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.
gtkspellmm30-3.0.1-1.fc18 has been pushed to the Fedora 18 stable repository.