Bug 920018 - System list should not show systems on disabled controllers
Summary: System list should not show systems on disabled controllers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.11
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 0.14.2
Assignee: Amit Saha
QA Contact: tools-bugs
URL:
Whiteboard: Misc
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-11 07:38 UTC by Jaroslav Kortus
Modified: 2018-02-06 00:41 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-11-07 01:47:32 UTC
Embargoed:


Attachments (Terms of Use)

Description Jaroslav Kortus 2013-03-11 07:38:29 UTC
Description of problem:
System list should not show systems on disabled controllers in Systems->Available nor in Systems->Free.

They should be shown in Systems->All. Preferably with some visible note that the system is not reachable ATM (like red color, text note in italics,...).

We may even need some additional state to flip systems to when their LC is disabled.

Version-Release number of selected component (if applicable):
0.11.3

How reproducible:
always

Steps to Reproduce:
1. Disable one LC
2. Check the systems appear in Systems->Available
3.
  
Actual results:
confusing view, where the systems are shown as available even though the system knows they are on disabled scheduler

Expected results:
* Unusable systems not shown in Available and Free
* "All" tab still showing them with visible note that they are currently disabled.

Additional info:

Comment 2 Amit Saha 2013-07-31 04:53:12 UTC
On Gerrit: http://gerrit.beaker-project.org/#/c/2135/1

Comment 3 Dan Callaghan 2013-08-02 04:11:45 UTC
(In reply to Jaroslav Kortus from comment #0)
> * Unusable systems not shown in Available and Free

The Available page is really telling you which systems you have permission to access (as in, "available to you"), not which systems are available to you right now (that's what the Free page is for). I'll admit the naming scheme does not make that particularly clear, nor is it documented anywhere...

But so for that reason, I think systems should remain listed on the Available page even when their LC is disabled. You have permission to access them, they are just temporarily out of service while the LC is disabled.

They should certainly not be listed in Free though.

> * "All" tab still showing them with visible note that they are currently disabled.

I don't think it's worthwhile inventing a new UI convention in the system grids just to indicate that a system's LC is disabled, given that that should be an exceedingly rare occurence.

In future when we have some better ways of taking systems out of service other than just setting Condition=Broken (e.g. system pools, bug 851354, bug 790492), I expect we would indicate that in the system grids. Being on a disabled LC would be counted as out of service.

Comment 5 wangjing 2013-08-08 03:03:39 UTC
verify on beaker-devel(2013.8.8)-->pass

steps:
1. set system1(non loan and non used) on one LC and Disable the LC
2. Check the system appear in Systems->All
3. Check the system appear in Systems->Available
4. Check the system appear in Systems->Free
5. check the system via CLI:
bkr list-systems
bkr list-systems --available
bkr list-systems --free

actual result:
1. system1 appear on Systems->All, Systems->Available.
2. system1 doesn't appear on Systems->Free.
3. system1 is returned via 'bkr list-systems/bkr list-systems --available'.
4. System1 is not returned via 'bkr list-systems --free'.

expected result:
same as actual result.

Comment 6 Nick Coghlan 2013-10-03 02:29:36 UTC
Beaker 0.15 has been released.

Comment 7 Raymond Mancy 2013-10-23 01:57:07 UTC
This change has been nominated to be back ported to the 0.14 branch, to be released as part of the next maintenance release 0.14.2.

Comment 8 Nick Coghlan 2013-10-25 06:36:30 UTC
Adjusting target milestone to make the changes backported to 0.14.2 easier to identify. 0.15.0 has enough significant regressions that it shouldn't be used, so the change means that 0.15.1 can be effectively reidentified as the union of that tag and the 0.14.2 target milestone.

Comment 10 wangjing 2013-10-28 09:19:59 UTC
verify on beaker-devel(2013.10.28)-->pass

steps:
1. set system1(non loan and non used) on one LC and Disable the LC
2. Check the system appear in Systems->All
3. Check the system appear in Systems->Available
4. Check the system appear in Systems->Free
5. check the system via CLI:
bkr list-systems
bkr list-systems --available
bkr list-systems --free

actual result:
1. system1 appear on Systems->All, Systems->Available.
2. system1 doesn't appear on Systems->Free.
3. system1 is returned via 'bkr list-systems/bkr list-systems --available'.
4. System1 is not returned via 'bkr list-systems --free'.

expected result:
same as actual result.

Comment 11 Nick Coghlan 2013-11-07 01:47:32 UTC
Closing as addressed in Beaker 0.14.2.


Note You need to log in before you can comment on or make changes to this bug.