Spec URL: http://www.matthias-runge.de/fedora/python-sqlalchemy0.7.spec SRPM URL: http://www.matthias-runge.de/fedora/python-sqlalchemy0.7-0.7.3-8.fc18.src.rpm Description: Modular and flexible ORM library for python Fedora Account System Username: mrunge This is a re-review required for un-orphaning f18/f19 brances of https://admin.fedoraproject.org/pkgdb/acls/name/python-sqlalchemy0.7
* Buildroot: present but not needed * Consider putting nearly 6 MB of documentation into separate -doc package. Otherwise looks good to me. My fedora-review: Issues: ======= - Large documentation must go in a -doc subpackage. Note: Documentation size is 5632000 bytes in 184 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/vagrant/920128-python- sqlalchemy0.7/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [?]: Python eggs must not download any dependencies during the build process. [?]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5836800 bytes in /usr/share 5836800 python-sqlalchemy0.7-0.7.3-8.fc18.x86_64.rpm [x]: Rpmlint is run on all installed packages. ------- Checking: python-sqlalchemy0.7-0.7.3-8.fc18.x86_64.rpm python-sqlalchemy0.7.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy0.7-0.7.3/examples/dynamic_dict/dynamic_dict.py 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-sqlalchemy0.7 python-sqlalchemy0.7.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy0.7-0.7.3/examples/dynamic_dict/dynamic_dict.py 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- python-sqlalchemy0.7 (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) python(abi) rtld(GNU_HASH) Provides -------- python-sqlalchemy0.7: python-sqlalchemy0.7 python-sqlalchemy0.7(x86-64) Unversioned so-files -------------------- python-sqlalchemy0.7: /usr/lib64/python2.7/site-packages/SQLAlchemy-0.7.3-py2.7-linux-x86_64.egg/sqlalchemy/cprocessors.so python-sqlalchemy0.7: /usr/lib64/python2.7/site-packages/SQLAlchemy-0.7.3-py2.7-linux-x86_64.egg/sqlalchemy/cresultproxy.so MD5-sum check ------------- http://pypi.python.org/packages/source/S/SQLAlchemy/SQLAlchemy-0.7.3.tar.gz : CHECKSUM(SHA256) this package : 54e6e9fb30bef740b036c69cffbcb369cae2e61f95b69af4c086fca9c15308fa CHECKSUM(SHA256) upstream package : 54e6e9fb30bef740b036c69cffbcb369cae2e61f95b69af4c086fca9c15308fa Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -b 920128
thank you for the review. Will drop the buildroot line in the package. Also moving docs to a subpackage sounds sane to mee, too. That needs to be done also in the other package python-sqlalchemy, and as well in python-sqlalchemy0.7.
What is the status of this?
Thanks for the heads up. I must admit, I have totally forgotten this one. Currently, I assume, we don't need it at all, don't we? Pádraig?
I don't know why we'd ever need sqlalchemy0.7 on fedora branches