Bug 920225 - libguestfs should use --output json (if supported) to safely parse the output of qemu-img command
Summary: libguestfs should use --output json (if supported) to safely parse the output...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On: 861375
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-11 15:37 UTC by Richard W.M. Jones
Modified: 2013-03-11 19:12 UTC (History)
16 users (show)

Fixed In Version:
Clone Of: 861375
Environment:
Last Closed: 2013-03-11 19:12:59 UTC
Embargoed:

Attachments (Terms of Use)

Description Richard W.M. Jones 2013-03-11 15:37:15 UTC 
+++ This bug was initially created as a clone of Bug #861375 +++

qemu-img info currently give me info like this:

image: /home/alex/.local/share/gnome-boxes/images/Fedora 16
file format: qcow2
virtual size: 11G (11794287616 bytes)
disk size: 4.5G
cluster_size: 65536

[...]

Note upstream there is a patch floating around which adds
JSON output to qemu-img info.  This is useful because it's
a big security problem to try to parse the text output from
this command.  See:

https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg00137.html
Comment 1 Richard W.M. Jones 2013-03-11 19:12:59 UTC 
Fixed upstream:
https://github.com/libguestfs/libguestfs/commit/2f8960f7844274177185f65a636c9b511980a41e
https://github.com/libguestfs/libguestfs/commit/5e5026b730dfea1e940e961a5b7e516a9c9bda72
Note You need to log in before you can comment on or make changes to this bug.