Repository: https://github.com/mojavelinux/rubygem-bootstrap-sass-rpm Spec URL: https://raw.github.com/mojavelinux/rubygem-bootstrap-sass-rpm/master/rubygem-bootstrap-sass.spec SRPM URL: https://github.com/mojavelinux/rubygem-bootstrap-sass-rpm/raw/master/srpms/rubygem-bootstrap-sass-2.3.0.1-1.fc17.src.rpm Description: A Sass-powered version of Bootstrap, ready to drop right into your Sass-powered applications. Fedora Account System Username: mojavelinux
I've updated the RPM to bootstrap-sass-2.3.1.0 and applied patches that allow it to work with the version of Sass available on F18. Repository: https://github.com/mojavelinux/rubygem-bootstrap-sass-rpm Spec URL: https://raw.github.com/mojavelinux/rubygem-bootstrap-sass-rpm/master/rubygem-bootstrap-sass.spec SRPM URL: https://github.com/mojavelinux/rubygem-bootstrap-sass-rpm/raw/master/srpms/rubygem-bootstrap-sass-2.3.1.0-1.fc18.src.rpm
Dan, I would appreciate it if you would swap this review request with one of my rubygem-related review request (e.g. bug 922460 )
Anyway assigning. It seems that there is nothing special item for packaging this srpm, however one thing. * Conditional patch --------------------------------------- 48 # apply patches for distributions with Sass < 3.2 49 %if 0%{?rhel} < 7 || 0%{?fedora} < 19 --------------------------------------- - With this patches are always applied (because when fedora is defined, usually rhel is usually not defined): e.g. for F-19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5193352 and this is perhaps against your intend.
ping? By the way, bug 922460 is assigned, so instead I would appreciate it if you would review swaps with my other requests (e.g. bug 892314 )
I picked up that condition patch from another RPM that was built for both epel and fedora. I honestly don't know if it's right because I have yet to test epel packages. Do you know what the correct conditional is then? I will try to look at your other requests, but at the moment I am very short on time.
What I am saying is that NOT of %if 0%{?rhel} > 6 || 0%{?fedora} > 18 (as appears on the line 15 of your spec file) is %if 0%{?rhel} < 7 && 0%{?fedora} < 19 , not %if 0%{?rhel} < 7 || 0%{?fedora} < 19
ping again?
again ping?
I will close this bug if no response from the reporter is received within one week.
*** Bug 967331 has been marked as a duplicate of this bug. ***
Closing. If someone is interested in this package, please open a new review request, thank you.