Bug 920986 - Empty vds statistics may end up causing NPE
Summary: Empty vds statistics may end up causing NPE
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
urgent
medium
Target Milestone: ---
: 3.2.0
Assignee: Gilad Chaplik
QA Contact: Ido Begun
URL:
Whiteboard: sla
Depends On:
Blocks: 948448
TreeView+ depends on / blocked
 
Reported: 2013-03-13 09:10 UTC by Doron Fediuck
Modified: 2016-02-10 20:20 UTC (History)
10 users (show)

Fixed In Version: sf11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: SLA
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 12996 0 None None None Never

Description Doron Fediuck 2013-03-13 09:10:03 UTC 
Description of problem:
It seems that when the usage statistics of a VDS in the DB is empty (null),
a memory threashold check will cause NPE. The path to this DB situation is still being checked, but the NPE should be prevented.

Additional info:

 [org.ovirt.engine.core.vdsbroker.VdsUpdateRunTimeInfo]
 (DefaultQuartzScheduler_Worker-2) [617e62bb]
 NullPointerException:
 :
 java.lang.NullPointerException
         at org.ovirt.engine.core.vdsbroker.VdsUpdateRunTimeInfo.checkVdsMemoryThreshold(VdsUpdateRunTimeInfo.java:276)
         [vdsbroker.jar:]
         at org.ovirt.engine.core.vdsbroker.VdsUpdateRunTimeInfo.saveDataToDb(VdsUpdateRunTimeInfo.java:123)
         [vdsbroker.jar:]
         at org.ovirt.engine.core.vdsbroker.VdsUpdateRunTimeInfo.Refresh(VdsUpdateRunTimeInfo.java:391)
         [vdsbroker.jar:]
         at org.ovirt.engine.core.vdsbroker.VdsManager.OnTimer(VdsManager.java:234)
Comment 5 Ido Begun 2013-04-25 14:58:07 UTC 
OK - SF13.1

No NPE is throw when crossing the memory threshold. Instead, in audit log:
"Available memory of host xx.xx.x.xx [x MB] is under defined threshold [1024 MB]."
Comment 6 Itamar Heim 2013-06-11 08:32:09 UTC 
3.2 has been released
Comment 7 Itamar Heim 2013-06-11 08:32:10 UTC 
3.2 has been released
Comment 8 Itamar Heim 2013-06-11 08:33:21 UTC 
3.2 has been released
Note You need to log in before you can comment on or make changes to this bug.