Bug 921291 - [RFE] [PATCH] Macro for Node.js ExclusiveArch
Summary: [RFE] [PATCH] Macro for Node.js ExclusiveArch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F19FeatureNodeJS
TreeView+ depends on / blocked
 
Reported: 2013-03-13 22:09 UTC by T.C. Hollingsworth
Modified: 2013-06-07 04:33 UTC (History)
3 users (show)

Fixed In Version: redhat-rpm-config-9.1.0-45.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-07 04:33:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch adding %nodejs_arches macro (2.40 KB, patch)
2013-05-21 02:32 UTC, T.C. Hollingsworth
no flags Details | Diff

Description T.C. Hollingsworth 2013-03-13 22:09:51 UTC
The V8 JavaScript interpreter currently only supports x86, ARM, and MIPS.  Therefore, every binary Node.js package needs an ExclusiveArch line.

It would be nice to have a %nodejs_arches macro or such to define this so we don't have to change a ton of packages in the event V8 gains the ability to work on additional arches.  Unfortunately, we can't just define it in the macros file we ship along with the nodejs package since it needs to be present when koji does CreateSRPMfromSCM.

Definiting it thusly should be sufficient:
%nodejs_arches %{ix86} x86_64 %{arm}

I would provide a patch but I'm not sure which of /etc/rpm, /usr/lib/rpm[/redhat]/macros, or the new /usr/lib/rpm/macros.d this should live in. ;-)

Comment 1 T.C. Hollingsworth 2013-05-21 02:32:18 UTC
Created attachment 750803 [details]
patch adding %nodejs_arches macro

Sorry, not sure where my head was when I filed this bug.  Here's a patch now.

Comment 2 Stephen Gallagher 2013-05-28 13:09:27 UTC
Panu, can you commit the attached patch and get a release out? It's becoming a significant issue for Node.js packages in Fedora 19 (of which there are now dozens and more being added daily). The workaround is to patch each package individually, but that's a poor solution.

Comment 3 Fedora Update System 2013-05-29 10:23:36 UTC
redhat-rpm-config-9.1.0-45.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/redhat-rpm-config-9.1.0-45.fc19

Comment 4 Panu Matilainen 2013-05-29 10:29:15 UTC
BTW, thanks for the reminder / gentle kick in the butt. I had no clue of the importance (or lack of thereof) of whatever Node.js is and what it does, and stuff like has a certain tendency to get overlooked more easily than something "obviously" critical.

Comment 5 Fedora Update System 2013-05-29 17:44:21 UTC
Package redhat-rpm-config-9.1.0-45.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing redhat-rpm-config-9.1.0-45.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-9551/redhat-rpm-config-9.1.0-45.fc19
then log in and leave karma (feedback).

Comment 6 T.C. Hollingsworth 2013-05-30 01:25:39 UTC
Thanks for merging this Panu!  Any chance this could get backported to F18 also?  It would come in handy there as well.

Comment 7 Fedora Update System 2013-06-07 04:33:56 UTC
redhat-rpm-config-9.1.0-45.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.