Created attachment 710528 [details] Search pop-up Description of problem: Search bar pop-up doesn't hide after hit enter also, it breaks automation cases and not hide even if navigated to resource page. Version-Release number of selected component (if applicable): 4.7.0-SNAPSHOT (b350f10) How reproducible: 100% Steps to Reproduce: 1. Install RHQ [4.7.0-SNAPSHOT (b350f10)] 2. Navigate to "Inventory-->All Resources" 3. on Search box type "rhq agent" and hit enter 4. Do not mouse over on the pop-up produced by search box 5. Click "RHQ Agent" resource link 6. The pop-up will not hide until we put mouse over on the pop-up, even we moved to next page (resource page). Actual results: Once we hit enter search pop-up is not hiding Expected results: Once we hit enter search pop-up should hide Additional info: Screen shot is attached This issue was captured by SAHI GUI automation and it's a regression issue. It's blocking GUI automaiton. Browser: FF 10.x OS: RHEL 6.4
There are a couple of things at work here. Probably most important is that the Search bar has been re-implemented. The smartgwt combobox was flaky and unable to do what we needed. So, to get around fundamental issues Mike converted it to be TextBox based with a separate ListGrid for the suggestion box. This change of widgets is likely the issue with the automation. The second thing is that there were still outstanding issues with the new implementation. I've been working on those and it should be getting much more stable now. The following commit should now make it reasonable for automation to be changed as needed to accommodate the impl update. But before setting to ON_QA we'll do a little more review. master commit c3c5d36953256f25cf9a2ef24fe258f8c6ff2d1c Author: Jay Shaughnessy <jshaughn> Date: Mon Apr 1 16:39:48 2013 -0400 Work on search bar issues: - Add RecordDoubleClick handling to SearchStrategies, allows us to impl SavedSearch delete via DblClick. - Allow TableFilter to be disabled by SearchBar impl, allows SavedSearch mode to not trigger searches. - Add SavedSearch updateName/updatePattern/delete - Fix up keypress delay by canceling timer as needed - Add SavedSearch hover showing pattern in suggest list - Tie suggestion box size/positioning to search text box - Add some more ignored keys - A variety of other behavioral tweeks - Remove unncessary field defs in search strategy impls
I think this is stable enough for ON_QA. The following commit adds a little robustness. The implementation is set, so it should be safe to build automation on top. master commit 0e4fbbbc258cd3f90e5ba1136992440b619edd38 Author: Jay Shaughnessy <jshaughn> Date: Tue Apr 2 14:19:42 2013 -0400 - add confirm box for delete - add some tooltips - clean up some related message properties
master commit cdd21b21fc4fa8bb548c24a1147dd36704ebf0ac Author: Jay Shaughnessy <jshaughn> Date: Mon Apr 8 14:03:17 2013 -0400 Prevent concurrent searches for suggestion list entries or saved searches. Timing issues could cause duplicates to show up in the list. Also: - fix an issue with return key handling, which should not fire off another suggest list update but only hide the suggest list and perform the resource list query. - stop ignoring the Backspace character when editing the search textbox entry. I found it unintuitive that only adding characters could trigger a search.
master commit 948dc0e6400925aa4a15a9e5585928e080bc67d1 Author: Jay Shaughnessy <jshaughn> Date: Thu Apr 11 13:53:27 2013 -0400 Tried to make text boxes resize when browser is resized but failed to get it to work. I tried to emulate http://www.smartclient.com/smartgwt/showcase/#layout_form_spanning but it didn't seem to work within the Toolstrip. Instead, to better support narrow browsers I: - reduced the size of the search text box by 100 px - removed the unnecessary leader spacer of 40px - was able to fully hide the savedSearch text box space when not being used Also - Made one behavioral fix such that we hide the suggest box even if it's a duplicate search. This makes the behavior consistent, as if a real search had been performed. - Changed the search bar impl from ToolStrip to EnhancedToolstrip for better destroy handling. - Simplified EnhancedSearchBarItem to be just a stripped down wrapper - Wrapped the search and savedSearch TextItems in DynamicForms as per the jdoc for ToolStrip, to hopefully get best behavior.
Version: 4.9.0-SNAPSHOT Build Number: a9245fd GWT Version: 2.5.0 SmartGWT Version: 3.0 Working as expected. Once hit enter search box goes away.
Bulk closing of RHQ 4.9 verified items