Bug 922016 - Review Request: perl-File-Fetch - Generic file fetching mechanism
Summary: Review Request: perl-File-Fetch - Generic file fetching mechanism
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-15 12:01 UTC by Petr Pisar
Modified: 2013-03-18 09:43 UTC (History)
3 users (show)

Fixed In Version: perl-File-Fetch-0.38-1.fc20
Clone Of:
Environment:
Last Closed: 2013-03-18 09:43:46 UTC
Type: ---
Embargoed:
psabata: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2013-03-15 12:01:20 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-File-Fetch/perl-File-Fetch.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-File-Fetch/perl-File-Fetch-0.38-1.fc20.src.rpm
Description:
File::Fetch allows you to fetch any file pointed to by a "ftp", "http",
"file", or "rsync" URI by a number of different means.

Fedora Account System Username: ppisar

-----
This perl core package will dual-live with perl.spec's sub-package.

Comment 1 Petr Šabata 2013-03-15 13:22:36 UTC
perl(IO::Socket::INET) doesn't seem to be optional.  Is there a reason why you have omitted it in your BRs?

Comment 2 Petr Pisar 2013-03-15 13:41:04 UTC
    my $use_list = {
        'IO::Socket::INET' => '0.0',
        'IO::Select'       => '0.0',
    };

    unless( can_load(modules => $use_list) ) {
        $METHOD_FAIL->{'iosock'} = 1;
        return;
    }

Comment 3 Petr Šabata 2013-03-15 13:52:03 UTC
See lines 169, 188, and 206 in t/01_File-Fetch.t

Comment 4 Petr Pisar 2013-03-15 14:00:18 UTC
You are right. Updated package is on the same address.

Comment 5 Petr Šabata 2013-03-15 14:08:23 UTC
Ok, now I'm happy :)
Approving.

Comment 6 Petr Pisar 2013-03-15 14:11:21 UTC
New Package SCM Request
=======================
Package Name: perl-File-Fetch
Short Description: Generic file fetching mechanism
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2013-03-15 14:36:04 UTC
Unretired.

Comment 8 Petr Pisar 2013-03-15 14:47:18 UTC
Waiting on unblocking package <https://fedorahosted.org/rel-eng/ticket/5535>.

Comment 9 Petr Pisar 2013-03-18 09:43:46 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.