Bug 922280 - kate: pate(python) plugins not built/packaged
Summary: kate: pate(python) plugins not built/packaged
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kate
Version: 20
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Than Ngo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-15 23:17 UTC by T.C. Hollingsworth
Modified: 2013-12-20 23:33 UTC (History)
11 users (show)

Fixed In Version: kate-4.11.4-2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-12-20 23:33:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 318719 0 None None None Never

Description T.C. Hollingsworth 2013-03-15 23:17:46 UTC
Please backport this commit to Kate 4.10.1 so Pate will build against the PyQt4 currently in Fedora:
http://commits.kde.org/kate/106f4ee310796170a28786a32f2a235d5464f83c

Thanks!

Comment 1 Rex Dieter 2013-03-17 00:26:45 UTC
Taking off blocker tracker, looks like we've never shipped this plugin in kate before.

That said, we're happy to work to add it soon.

Comment 2 Rex Dieter 2013-04-26 13:07:40 UTC
I guess we have kde-4.10.2 out now, but we still don't enable pate by default, due to circular dependencies.

pykde4 Requires: kate-part
already, but in order to build pate, we'd have to add to kate.spec:

BuildRequires: pykde4


Are these plugins awesome enough to warrant the extra hassle of bootstrapping? (which requires building in 2 passes)

Comment 3 T.C. Hollingsworth 2013-04-27 03:01:42 UTC
(In reply to comment #2)
> Are these plugins awesome enough to warrant the extra hassle of
> bootstrapping? (which requires building in 2 passes)

Yes!  They're awesome enough for me to have been rebuilding the Kate SRPM with them for some time now, anyway.  ;-)

Here are some of the cool things they do:
http://kate-editor.org/2013/02/18/new-plugins-to-the-kate-utils-to-python-javascript-django-and-xml/
http://kate-editor.org/2013/04/23/a-rich-python-console-and-more-in-kate-editor/

Python is really big in Fedora so it would be very sad for these not to be working in Fedora's kate.  :-(

I know it would technically violate the one upstream tarball -> one SRPM rule, but I think Pate can be built on it's own (it used to be completely seperate until it got merged with the main Kate tree for 4.10).  Would this be preferable to building in 2 passes?  I wouldn't mind helping out by putting together the package if this turns out to be a more viable option.

Comment 4 Kevin Kofler 2013-04-27 20:25:20 UTC
We might be able to avoid the bootstrapping by using relaxed/no dependency versioning, but the separate pate SRPM might be the less ugly solution from a user standpoint (but more ugly from a packager standpoint).

Comment 5 Gerald Cox 2013-06-15 21:17:13 UTC
(In reply to T.C. Hollingsworth from comment #3)
> (In reply to comment #2)
> 
> Yes!  They're awesome enough for me to have been rebuilding the Kate SRPM
> with them for some time now, anyway.  ;-)
>

Yup, I'm getting into python now so this would be goodness...

Comment 6 Martin Vala 2013-09-06 21:23:59 UTC
Will it be in 4.11 (kde unstable repository)?

Thanks

Ciao

Martin

Comment 7 Kevin Kofler 2013-09-13 20:24:41 UTC
No. We're still stuck with the circular dependency.

Comment 8 Fedora End Of Life 2013-09-16 13:11:09 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 9 Edward O 2013-10-31 11:02:13 UTC
What about the solution proposed by T.C. Hollingsworth in Comment 3 ?

Comment 10 Rex Dieter 2013-10-31 12:29:53 UTC
Yes, I would accept a separate (something like) kate-pate package to avoid bootstrapping issues.

Bonus points to contact upstream to get them to resolve the bootstrapping problem for us somehow.

Comment 11 T.C. Hollingsworth 2013-11-01 21:07:30 UTC
Sorry, I use kate master generally anyway so I forgot about this.  :-/

Looking into this further, I think it makes more sense to split off kate-part into its own SRPM instead, since that's what pykde4 needs.  This is fully supported upstream with just a few cmake flags, whereas building pate by itself seems to be a pain.

This seems to work nicely:
http://patches.fedorapeople.org/katepart-split/
http://koji.fedoraproject.org/koji/taskinfo?taskID=6124133
http://koji.fedoraproject.org/koji/taskinfo?taskID=6124150

(I also fixed the SyntaxError when byte-compiling both in a patch and upstream.  :-)

Comment 12 Rex Dieter 2013-11-02 05:26:37 UTC
Pardon my ignorance, but how does a separate kate-part package help?

Comment 13 Rex Dieter 2013-11-02 05:28:22 UTC
Oh I see, you include the -devel pieces from kate-part pkg.  I'll look that over.

Comment 14 Rex Dieter 2013-11-02 21:44:50 UTC
Tried building kate-4.11.3 with pate enabled, and the build still fails.  Was that upstream commit to master/ only and not backported to 4.11 branch?  If so, why?

Comment 15 T.C. Hollingsworth 2013-11-02 22:14:18 UTC
I committed it to master and KDE/4.11 simultaneously, but it missed 4.11.3 by a day and a half.  :-(  It'll be in 4.11.4.

http://quickgit.kde.org/?p=kate.git&a=commit&h=db0e2c6ddf3d909364e47c7daff68ee624d951c8

Comment 16 Rex Dieter 2013-11-03 00:19:02 UTC
OK, thanks, I'll pull that in.

Comment 17 Rex Dieter 2013-11-03 01:10:20 UTC
I guess I'll risk the bootstrapping pain for now.  If it ends up being too much, we can consider the kate, kate-part srpm split as suggested.

%changelog
* Sat Nov 02 2013 Rex Dieter <rdieter> 4.11.3-2
- kate: pate(python) plugins not built/packaged (#922280)

We'll roll this in to the upcoming kde-4.11.3 update

Comment 18 Edward O 2013-11-06 09:45:30 UTC
I confirm I could successfully install the new package on Rawhide (the plugin activation fails on python import errors, but this is another bug for another day ;-))

Thanks for the quick action !

Comment 19 T.C. Hollingsworth 2013-11-10 23:43:50 UTC
(In reply to edoubrayrie from comment #18)
> I confirm I could successfully install the new package on Rawhide (the
> plugin activation fails on python import errors, but this is another bug for
> another day ;-))

There are two issues:

1. A few of the plugins are missing requires.  See bug 1028819.

2. Two more of the plugins (cmake_utils and expand) aren't compatible with Python 2.  I'm working upstream to fix this (which may just mean not installing them when python 2 is used).

Comment 20 Rex Dieter 2013-12-02 15:06:24 UTC
Arg, 

https://projects.kde.org/projects/kde/applications/kate/repository/revisions/3115a93d4f35cdb9ab37768cdc90a944c0a7f36d

T.C., your commit fixing this upstream was reverted, which rebreaks things for us.  Can you poke alex about this?  (Or I can if you want)

Comment 21 T.C. Hollingsworth 2013-12-02 21:36:55 UTC
Yeah, that patch wasn't very correct because I didn't realize that plugin didn't work with Python 2 at all.  The real fix is not to bother installing Python 3 only plugins on Python 2; then you don't get SyntaxErrors or useless plugins.  :-)

So, I just filed a review with a better patch that skips installation altogether of plugins incompatible with the Python version Kate is built against:
https://git.reviewboard.kde.org/r/114264/

With this + the new Requires (I'll finish up those reviews next) we should have all plugins working with no tracebacks for 4.11.4, yay!

Comment 22 T.C. Hollingsworth 2013-12-04 18:29:55 UTC
(In reply to T.C. Hollingsworth from comment #21)
> Yeah, that patch wasn't very correct because I didn't realize that plugin
> didn't work with Python 2 at all.  The real fix is not to bother installing
> Python 3 only plugins on Python 2; then you don't get SyntaxErrors or
> useless plugins.  :-)

Fixed upstream in http://commits.kde.org/kate/41e15427a6d6083ead538af0584804e33cbdfc4c

Comment 23 T.C. Hollingsworth 2013-12-14 18:40:23 UTC
Sorry, the above patch didn't get reviewed in time for 4.11.4.  :-(

Should be fixed for really real now:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6294717
http://koji.fedoraproject.org/koji/taskinfo?taskID=6294719

(Provenpackagered in officially because upgradepath issues, but really because you've wasted enough time on this silly brokenness.  ;-)

Sorry for all the trouble here.

Comment 24 Rex Dieter 2013-12-15 20:40:22 UTC
Thanks!

Comment 25 T.C. Hollingsworth 2013-12-20 23:33:20 UTC
Working great now, thanks!


Note You need to log in before you can comment on or make changes to this bug.