Bug 923470 - Review Request: python-q - Quick and dirty python debugging output
Summary: Review Request: python-q - Quick and dirty python debugging output
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Xavier Lamien
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 950313 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-19 23:41 UTC by Toshio Ernie Kuratomi
Modified: 2014-09-29 12:05 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-01 22:25:33 UTC
Type: ---
Embargoed:
lxtnow: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Toshio Ernie Kuratomi 2013-03-19 23:41:22 UTC
Spec URL: http://toshio.fedorapeople.org/packages/python-q.spec
SRPM URL: http://toshio.fedorapeople.org/packages/python-q-1.1-1.fc17.src.rpm
Description: 
If you've ever been frustrated trying to debug with print because a web
application or a unittesting framework is swallowing your debugging output,
q will make you jump for joy.

  import q
  variable = 'Hmmm... something happened here'
  q.q(variable)

cat /tmp/q

Fedora Account System Username: toshio

Comment 1 Xavier Lamien 2013-03-20 00:14:54 UTC
key:
[+] OK
[.] OK, not applicable
[X] needs work

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.

--> Found warnings which can definitely be ignored.[1]

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.

PROBLEM SEE BELOW: [X] MUST: The package must meet the Packaging Guidelines.
ADDED: [+] in addition check the python specific Guidelines

[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
 --> Built on local machine (rpmbuild & mock): OK
 --> Built on koji as scratch build: OK

[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.[11]
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
[.] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[.] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency.
[.] MUST: Packages must NOT contain any .la libtool archives
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[.] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.

[.] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.

[+] SHOULD: The reviewer should test that the package builds in mock.
[.] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.

 --> Tested as described in description from python console.


[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.


Sound pretty good and interesting python tools ;)
This package is a pass for me.

Comment 2 Toshio Ernie Kuratomi 2013-03-20 05:58:24 UTC
New Package SCM Request
=======================
Package Name: python-q
Short Description: Quick and dirty python debugging output
Owners: toshio
Branches: f17 f18 f19 el6
InitialCC:

Comment 3 Pavol Babinčák 2013-03-20 10:44:05 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-03-21 18:45:27 UTC
python-q-1.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-q-1.1-1.fc18

Comment 5 Fedora Update System 2013-03-21 18:45:39 UTC
python-q-1.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-q-1.1-1.fc17

Comment 6 Fedora Update System 2013-03-21 18:45:54 UTC
python-q-1.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-q-1.1-1.el6

Comment 7 Fedora Update System 2013-04-01 22:25:34 UTC
python-q-1.1-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2013-04-01 22:35:01 UTC
python-q-1.1-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2013-04-05 22:35:22 UTC
python-q-1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Ralph Bean 2013-04-19 03:53:14 UTC
*** Bug 950313 has been marked as a duplicate of this bug. ***

Comment 11 Toshio Ernie Kuratomi 2014-09-29 02:46:18 UTC
Package Change Request
======================
Package Name: python-q
New Branches: epel7
Owners: toshio ralph oddshocks

Comment 12 Gwyn Ciesla 2014-09-29 12:05:21 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.