Bug 923889 - vnic with "dual mode" on vm with agent should be reported to the vdsm as "virtio" only
Summary: vnic with "dual mode" on vm with agent should be reported to the vdsm as "vir...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.2.0
Assignee: Alona Kaplan
QA Contact: Meni Yakove
URL:
Whiteboard: network
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-20 16:44 UTC by Alona Kaplan
Modified: 2016-02-10 19:55 UTC (History)
9 users (show)

Fixed In Version: sf13.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 13558 0 None None None Never

Description Alona Kaplan 2013-03-20 16:44:08 UTC
Description of problem:
In case the vm interface has "dual mode" and the vm has agent-
two interfaces with the same entries except nic type are sent to the vdsm (one with "VirtIO" type and the second with "rtl8139" type).

The correct behaviour is that if the vm has guest agent just one interface with "VirtIO" type should be sent to the vdsm.

This fix was already done for 3.0, but somehow introduced again in 3.2 (http://gerrit.ovirt.org/#/c/9491/7).

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 2 Alona Kaplan 2013-04-04 15:02:07 UTC
After another look at the code- there is a snippet of code preparing the second interface. But this interface is not sent to the vdsm.
It means there is no real bug, just unused code.

But while testing this bug I found out that if there is no active ISO Domain in the dc the 'hasAgent' always returns false. So, even if there is an agent the 'dual mode' is reported as 'rtl8139' and not 'VirtIO'.

How to reproduce:
1. add a new vnic to the vm.
2. change the vnic's type manually in the db to 0 ('vm_interface' table, 'type' column).
3. install rhev-guest-agent on the vm.
4. make sure there is no active ISO domain in the dc.
5. run the vm.
6. check the vdsm logs.

Actual results:
'rtl8139' vnic type is sent to the vdsm (instead the dual mode).


Expected results:
'VirtIO' vnic type should be sent to the vdsm (instead the dual mode).

Comment 3 Meni Yakove 2013-04-14 12:25:42 UTC
Verified with rhevm-guest-agent-1.0.5-8.el6ev.x86_64.

See BZ https://bugzilla.redhat.com/show_bug.cgi?id=951916 for newer guest version.

Comment 4 Itamar Heim 2013-06-11 08:59:31 UTC
3.2 has been released

Comment 5 Itamar Heim 2013-06-11 08:59:31 UTC
3.2 has been released

Comment 6 Itamar Heim 2013-06-11 08:59:33 UTC
3.2 has been released

Comment 7 Itamar Heim 2013-06-11 09:01:04 UTC
3.2 has been released

Comment 8 Itamar Heim 2013-06-11 09:30:33 UTC
3.2 has been released


Note You need to log in before you can comment on or make changes to this bug.