Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-character-map.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-character-map-1.5.0-2.fc20.src.rpm Description: This program allows you to browse through all the available Unicode characters and categories for the installed fonts, and to examine their detailed properties. It is an easy way to find the character you might only know by its Unicode name or code point. Fedora Account System Username: raveit65
Update to MATE 1.6.0 Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-character-map.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-character-map-1.6.0-1.fc20.src.rpm
Dan, after 40 days of no action from you, i quess you're revised and have no time to review the request. Please do an action over the weekend. I think you agree that i reset 'assigned to' to nobody after the weekend, because of non blocking other potential reviewers.
New mock build: * Sat May 11 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-2 - fix license informations - try fix unused-direct-shlib-dependency - create -data noarch subpackage - move locale to -data subpackage - move help dir to -data subpackage - organized rpm scriplets Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-character-map.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-character-map-1.6.0-2.fc20.src.rpm
I'll do the review.
Somewhat strange: Is it really intended to have the localization and help files in a -data subpackage which is anyway installed as a dependency? If you recognize the help files too large, put them into a -doc subpackage. This way the users consider it correctly. The localization files should remain in the main package, as usual for other software (e.g. for GNOME). Or are there special rules for MATE packages which are not covered by the packaging guidelines yet? In any case, the current behavior is confusing for me. %{_libdir}/girepository-1.0 Your package owns the whole folder. But it is already owned by gobject-introspection. Please use %{_libdir}/girepository-1.0/* instead. Due to the gobject-introspection-devel build requirement, the runtime dependency should be picked up automatically.
Mario, thank you for doing the review and for your hints. I've removed the -data subpackage. New mock build: * Mon May 20 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-3 - do not own %%{_libdir}/girepository-1.0 - remove -data subpackage - remove %%check and use %%install for desktop-file-validate Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-character-map.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-character-map-1.6.0-3.fc20.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5419845 $ rpmlint -i -v * mate-character-map.i686: I: checking mate-character-map.i686: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) mate-character-map.i686: W: no-manual-page-for-binary mate-character-map Each executable in standard binary directories should have a man page. mate-character-map.i686: W: no-manual-page-for-binary mucharmap Each executable in standard binary directories should have a man page. mate-character-map.src: I: checking mate-character-map.src: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) mate-character-map.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 10) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. mate-character-map.src: I: checking-url http://pub.mate-desktop.org/releases/1.6/mate-character-map-1.6.0.tar.xz (timeout 10 seconds) mate-character-map.x86_64: I: checking mate-character-map.x86_64: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) mate-character-map.x86_64: W: no-manual-page-for-binary mate-character-map Each executable in standard binary directories should have a man page. mate-character-map.x86_64: W: no-manual-page-for-binary mucharmap Each executable in standard binary directories should have a man page. mate-character-map-debuginfo.i686: I: checking mate-character-map-debuginfo.i686: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) mate-character-map-debuginfo.x86_64: I: checking mate-character-map-debuginfo.x86_64: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) mate-character-map-devel.i686: I: checking mate-character-map-devel.i686: W: spelling-error %description -l en_US mcharmap -> armchair The value of this tag appears to be misspelled. Please double-check. mate-character-map-devel.i686: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) mate-character-map-devel.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. mate-character-map-devel.i686: E: incorrect-fsf-address /usr/include/mucharmap-2.0/mucharmap/mucharmap.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. mate-character-map-devel.x86_64: I: checking mate-character-map-devel.x86_64: W: spelling-error %description -l en_US mcharmap -> armchair The value of this tag appears to be misspelled. Please double-check. mate-character-map-devel.x86_64: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) mate-character-map-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. mate-character-map-devel.x86_64: E: incorrect-fsf-address /usr/include/mucharmap-2.0/mucharmap/mucharmap.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. mate-character-map.spec:10: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 10) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. mate-character-map.spec: I: checking-url http://pub.mate-desktop.org/releases/1.6/mate-character-map-1.6.0.tar.xz (timeout 10 seconds) 7 packages and 1 specfiles checked; 2 errors, 10 warnings. Don't bother with incorrect FSF addresses, just file a bug upstream. The one and only considerable problem is the mixed use of spaces and tabs in your spec. Please fix this before you upload the srpm into the Git repo. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. GPLv2+ and LGPLv3+ [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. 14a18a02db1a7a966d74229350eec64468e0aaf47ec5726a1b2042def9719635 mate-character-map-1.6.0.tar.xz 14a18a02db1a7a966d74229350eec64468e0aaf47ec5726a1b2042def9719635 mate-character-map-1.6.0.tar.xz.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [+] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [+] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [+] MUST: Development files must be in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ---------------- PACKAGE APPROVED ----------------
Thank you Mario for the review. I will fix the rest before i upload to fed git. The incorrect FSF addresses is already fixed in upstream. New Package SCM Request ======================= Package Name: mate-character-map Short Description: Unicode character picker and font browser Owners: raveit65 Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
mate-character-map-1.6.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-character-map-1.6.0-4.fc18
mate-character-map-1.6.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mate-character-map-1.6.0-4.fc19
mate-character-map-1.6.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-character-map-1.6.0-4.fc17
mate-character-map-1.6.0-4.fc19 has been pushed to the Fedora 19 testing repository.
mate-character-map-1.6.0-4.fc19 has been pushed to the Fedora 19 stable repository.
mate-character-map-1.6.0-4.fc18 has been pushed to the Fedora 18 stable repository.
mate-character-map-1.6.0-4.fc17 has been pushed to the Fedora 17 stable repository.