Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-applet-lockkeys.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-applet-lockkeys-0.2.0-1.fc20.src.rpm Description: Keyboard LED indicator applet for the MATE desktop environment. Fedora Account System Username: raveit65
Dan, after 40 days of no action from you, i quess you're revised and have no time to review the request. Please do an action over the weekend. I think you agree that i reset 'assigned to' to nobody after the weekend, because of non blocking other potential reviewers.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5335821 Minor TODOs: Please change the URL to http://www.zavedil.com/mate-lock-keys-applet/ Also remove NEWS from docs since this file is empty. Please note I only have a virtual console for testing the functionality: using it, I've been able to succeed with CapsLock and NumLock, but ScrollLock fails. Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: glib-compile-schemas is run if required Note: gschema file(s) in mate-applet-lockkeys [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: The spec file handles locales properly. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in mate-applet-lockkeys [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 7 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mate-applet-lockkeys-0.2.0-1.fc20.x86_64.rpm mate-applet-lockkeys.x86_64: E: zero-length /usr/share/doc/mate-applet-lockkeys-0.2.0/NEWS 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mate-applet-lockkeys mate-applet-lockkeys.x86_64: E: zero-length /usr/share/doc/mate-applet-lockkeys-0.2.0/NEWS 1 packages and 0 specfiles checked; 1 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- mate-applet-lockkeys (rpmlib, GLIBC filtered): /bin/sh libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libmate-panel-applet-4.so.1()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) mate-panel rtld(GNU_HASH) Provides -------- mate-applet-lockkeys: mate-applet-lockkeys mate-applet-lockkeys(x86-64) MD5-sum check ------------- http://www.zavedil.com/wp-content/uploads/2013/02/mate-applet-lockkeys-0.2.0.tar.gz : CHECKSUM(SHA256) this package : 531be2131879738ad87db94ab3bdc3ba737dd07a9b4c44a641bed290320377ef CHECKSUM(SHA256) upstream package : 531be2131879738ad87db94ab3bdc3ba737dd07a9b4c44a641bed290320377ef Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -n mate-applet-lockkeys -m fedora-rawhide-x86_64 APPROVED
Thank you Patrick for review. I will include your hints before uploading to git. @ ScrollLock This is a known issue, scrollock doesn't work in general for this package. Assen knows about this.
New Package SCM Request ======================= Package Name: mate-applet-lockkeys Short Description: MATE Keyboard LED indicator Owners: raveit65 Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
Patrick, i'm still wondering about your hint with the download link If i use http://www.zavedil.com/wp-content/uploads/2013/02/mate-applet-lockkeys-0.2.0.tar.gz ,than the download works. http://www.zavedil.com/mate-lock-keys-applet/mate-applet-lockkeys-0.2.0.tar.gz gives me an error.
Opps, i got it, you meant the url.
mate-applet-lockkeys-0.2.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-applet-lockkeys-0.2.0-2.fc18
mate-applet-lockkeys-0.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mate-applet-lockkeys-0.2.0-2.fc19
mate-applet-lockkeys-0.2.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-applet-lockkeys-0.2.0-2.fc17
About comment 7: Yes, you finally got it :-)
mate-applet-lockkeys-0.2.0-2.fc18 has been pushed to the Fedora 18 testing repository.
mate-applet-lockkeys-0.2.0-2.fc17 has been pushed to the Fedora 17 stable repository.
mate-applet-lockkeys-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository.
Package Change Request ====================== Package Name: mate-applet-lockkeys New Branches: epel7 Owners: raveit65 InitialCC:
http://koji.fedoraproject.org/koji/buildinfo?buildID=569606