Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-user-share.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-user-share-1.5.0-2.fc20.src.rpm Description: mate-user-share is a small package that binds together various free software projects to bring easy to use user-level file sharing to the masses. Fedora Account System Username:
Update for MATE 1.6 release Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-user-share.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-user-share-1.6.0-1.fc20.src.rpm
Dan, after 40 days of no action from you, i quess you're revised and have no time to review the request. Please do an action over the weekend. I think you agree that i reset 'assigned to' to nobody after the weekend, because of non blocking other potential reviewers.
This is intriguing. We see changelog entries dating back to Jul 19 2012, but this review request was only started this year. Has another review request for this package been submitted in the past?
No, i've start building this package for an external repo for MATE desktop. http://forums.fedoraforum.org/showthread.php?t=276286 I will delete those entries in the next build and start with 'initial build for fedora' :)
Please leave those entries there. There's nothing wrong with migrating a pre-existing package into Fedora. There's no reason to start with a fresh changelog.
Ok, can i do something for you?
New mock build: * Sat May 11 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-2 - remove gsettings.convert file - add requires highcolor-icon-theme - add desktop file check for mate-user-share.desktop Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-user-share.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-user-share-1.6.0-2.fc20.src.rpm
I'll review this one.
Full review done, results: Good: ==== - rpmlint checks return: mate-user-share.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/mate-user-share.desktop 3 packages and 0 specfiles checked; 0 errors, 1 warnings. This warning can be ignored - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file properly validated Needs work: ======== - You're using an upstream tarbal, so there should be no need to run autogen.sh, if there is a specific reason for this, please add a comment to the specfile why you're running autogen.sh. Note that %configure has been modified in newer redhat-rpm-config versions to take care of aarch64 issues, so if that is the reason you can drop the autogen.sh call. - desktop-file-validate is usually called from %install, %check is intended for packages with come with test-suites to run the test-suite. ie make test / make check
(In reply to Hans de Goede from comment #9) > Full review done, results: <snip> > Needs work: > ======== > - You're using an upstream tarbal, so there should be no need to run > autogen.sh, if there is a specific reason for this, please add a comment to > the specfile why you're running autogen.sh. Note that %configure has been > modified in newer redhat-rpm-config versions to take care of aarch64 issues, > so if that is the reason you can drop the autogen.sh call. > - desktop-file-validate is usually called from %install, %check is intended > for packages with come with test-suites to run the test-suite. ie make test > / make check Thanks for your hints. I will removed %check and use %install for desktop-file-validate. All current MATE tarballs comes without configure and make files, they have only configure.ac/in and Makefile.am include. For this reason i use NOCONFIGURE=1 ./autogen.sh to create them. New mock build: * Mon May 20 2013 Wolfgang Ulbrich <chat-to-me> - 1.6.0-3 - remove %%check - add a comment for usage of autogen.sh Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mate-user-share.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mate-user-share-1.6.0-3.fc20.src.rpm
Looks good now. approved!
Thank you for the review Hans. New Package SCM Request ======================= Package Name: mate-user-share Short Description: Mate user file sharing Owners: raveit65 Branches: f17 f18 f19 InitialCC:
Git done (by process-git-requests).
mate-user-share-1.6.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-user-share-1.6.0-3.fc17
mate-user-share-1.6.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-user-share-1.6.0-3.fc18
mate-user-share-1.6.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mate-user-share-1.6.0-3.fc19
mate-user-share-1.6.0-3.fc19 has been pushed to the Fedora 19 testing repository.
mate-user-share-1.6.0-3.fc19 has been pushed to the Fedora 19 stable repository.
mate-user-share-1.6.0-3.fc17 has been pushed to the Fedora 17 stable repository.
mate-user-share-1.6.0-3.fc18 has been pushed to the Fedora 18 stable repository.
Package Change Request ====================== Package Name: mate-user-share New Branches: epel7 Owners: raveit65