Spec URL: http://gimp-hpf.zom.dk/gimp-high-pass-filter.spec SRPM URL: http://gimp-hpf.zom.dk/gimp-high-pass-filter-1.2-1.fc18.src.rpm Description: Simple high-pass filter script for the GIMP, as requested by the fedora design team. Fedora Account System Username: paller
rpmlint: gimp-high-pass-filter.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. I tried to preserve the time stamp from the server, but I'm constantly getting the current date.
Hi, Full review done: Good: - rpmlint checks return: gimp-high-pass-filter.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, matches source - text not in doc, but given the special nature of the upstream "repo" that is ok - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - no need for .desktop file Should fix (but not a blocker): - Summaries should not begin with "A" or "The", so please drop the "A " from the Summary Approved! Note now that you've been sponsored, it is no longer my "duty" as your sponsor to review your packages. I did this one as it was very straight-forward. But for your next package, please don't assign the review to me. The easiest way to get a review done is to find someone to swap reviews with, usually this is done by sending a mail to the fedora-devel list with as subject: "Review swaps" and then you say I've this and this package to be reviewed, if you can review one for me, I'll review one of your packages (or some such in your own words). An added advantages in doing review swaps is that it keeps things fair, you will end up doing approx. as much reviews as that others are doing reviews for you. Regards, Hans
Thank you very much, I just thought I still needed training wheels :) Regards, Palle
New Package SCM Request ======================= Package Name: gimp-high-pass-filter Short Description: High-pass filter for the GIMP Owners: paller Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
gimp-high-pass-filter-1.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gimp-high-pass-filter-1.2-1.fc17
gimp-high-pass-filter-1.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gimp-high-pass-filter-1.2-1.fc18
gimp-high-pass-filter-1.2-1.fc17 has been pushed to the Fedora 17 testing repository.
gimp-high-pass-filter-1.2-1.fc18 has been pushed to the Fedora 18 stable repository.
gimp-high-pass-filter-1.2-1.fc17 has been pushed to the Fedora 17 stable repository.