Hi.

There is not any License file in source archive (http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text). 
Have you already requested the inclusion to upstream ?

I have not done that yet.

v24 is out!

NEWS?

SPEC updated and version upped to 24, files still located at gimp-elsamuko.zom.dk

1. You need to request a license file from upstream and ship it in the tarball(you can ask upstream to regenerate one). Better not add a separate license file by yourself instead.

2. %{_datarootdir} -> %{_datadir}

3. Add a comment in %build like "Nothing to build" to indicate that no need to build anything here.

4. If you don't have any special need, you should remove threaded blank lines.

Others are fine.

(In reply to Christopher Meng from comment #6)
> 1. You need to request a license file from upstream and ship it in the
> tarball

I have emailed Samuel Elsamuko and awaiting his response.

> 2. %{_datarootdir} -> %{_datadir}

Done.

> 3. Add a comment in %build like "Nothing to build" to indicate that no need
> to build anything here.

I find it self explaining, but added it anyway.

> 4. If you don't have any special need, you should remove threaded blank
> lines.

It's a topic for endless debate. I use 2 empty lines in all my SPEC files, and I will continue doing so. "All RPM sections, starting from %description, should be separated by two empty lines." -cite http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines

The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk

(In reply to Palle Ravn from comment #7)
> (In reply to Christopher Meng from comment #6)
> > 1. You need to request a license file from upstream and ship it in the
> > tarball
> 
> I have emailed Samuel Elsamuko and awaiting his response.

Fine.

> > 2. %{_datarootdir} -> %{_datadir}
> 
> Done.

Done?

%{_datarootdir}/gimp/2.0/scripts/*.scm

> > 4. If you don't have any special need, you should remove threaded blank
> > lines.
> 
> It's a topic for endless debate. I use 2 empty lines in all my SPEC files,
> and I will continue doing so. "All RPM sections, starting from %description,
> should be separated by two empty lines." -cite
> http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines
> 
> The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk

Peter is not god or standard as far as I know. But I never force you to change the style, I only wanted you to remove these:

Source0:        https://sites.google.com/site/elsamuko/gimp/elsamuko.zip

Requires:       gimp

BuildArch:      noarch

--------------->
Source0:        https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
Requires:       gimp
BuildArch:      noarch

----------------
PACKAGE APPROVED.

Please remember to add COPYING file as %doc when upstream releases new tarball. *This is a MUST*.

Also, it's better to leave a blank line between each changelog.

(In reply to Christopher Meng from comment #8)
> > > 2. %{_datarootdir} -> %{_datadir}
> > 
> > Done.
> 
> Done?
> 
> %{_datarootdir}/gimp/2.0/scripts/*.scm

I missed that one, sorry for that.

> > > 4. If you don't have any special need, you should remove threaded blank
> > > lines.
> > 
> > It's a topic for endless debate. I use 2 empty lines in all my SPEC files,
> > and I will continue doing so. "All RPM sections, starting from %description,
> > should be separated by two empty lines." -cite
> > http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines
> > 
> > The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk
> 
> Peter is not god or standard as far as I know. But I never force you to
> change the style, I only wanted you to remove these:
> 
> Source0:        https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
> 
> Requires:       gimp
> 
> BuildArch:      noarch
> 
> --------------->
> Source0:        https://sites.google.com/site/elsamuko/gimp/elsamuko.zip
> Requires:       gimp
> BuildArch:      noarch
> 
> ----------------

I misunderstood that one. I will remove the empty lines.

> Please remember to add COPYING file as %doc when upstream releases new
> tarball. *This is a MUST*.

I made a comment in the %files section to remember this.

(In reply to Christopher Meng from comment #9)
> Also, it's better to leave a blank line between each changelog.

I will start doing that.

New Package SCM Request
=======================
Package Name: gimp-elsamuko
Short Description: Script collection for the GIMP
Owners: paller
Branches: f19 f20
InitialCC:

Git done (by process-git-requests).

gimp-elsamuko-24-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gimp-elsamuko-24-2.fc20

gimp-elsamuko-24-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gimp-elsamuko-24-2.fc19

gimp-elsamuko-24-2.fc19 has been pushed to the Fedora 19 stable repository.

gimp-elsamuko-24-2.fc20 has been pushed to the Fedora 20 stable repository.

Package Change Request
======================
Package Name: 
New Branches: 
Owners: 
InitialCC: design-sw

Add to Design Software group