Bug 924735 - Upgrade to ann_1.1.2?
Summary: Upgrade to ann_1.1.2?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ann
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-22 11:51 UTC by Ralf Corsepius
Modified: 2013-08-27 23:37 UTC (History)
1 user (show)

Fixed In Version: ann-1.1.2-3.fc18
Clone Of:
Environment:
Last Closed: 2013-08-27 23:24:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ralf Corsepius 2013-03-22 11:51:48 UTC
Description of problem:

http://www.cs.umd.edu/~mount/ANN/
tells 1.1.2 is out since June 2010.

Fedora ships ann-1.1.1, which is hopelessly outdated (2006).

As ann-1.1.2 seems to be compatible to ann-1.1.1 (Some parts of the Fedora patches seem to be moved and some internal bugs be fix) and as nothing in Fedora seems to be using ann, I'd propose ann to be updated to 1.1.2 in all versions of Fedora.

Additional info: 
I'd have rebased-patches ready, which I could commit at any time.

Comment 1 Dan Horák 2013-03-22 12:04:22 UTC
Oh, there is a new version, it looked as a dead project when I checked last time. Please go ahead and thanks for the info.

Dan

Comment 2 Fedora Update System 2013-03-22 15:26:18 UTC
ann-1.1.2-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ann-1.1.2-1.fc18

Comment 3 Ralf Corsepius 2013-03-22 15:34:24 UTC
Taking ... ann-1.1.2 builds are on the way for f17-f20.

Comment 4 Fedora Update System 2013-03-22 15:47:00 UTC
ann-1.1.2-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/ann-1.1.2-1.fc17

Comment 5 Dan Horák 2013-03-22 16:02:02 UTC
BTW, did you try abi-compliance-checker to see what are the changes in API/ABI (if any)? It can be useful for consumers outside Fedora, IIRC FreeCAD has been using ANN.

Comment 6 Ralf Corsepius 2013-03-22 16:28:24 UTC
(In reply to comment #5)
> BTW, did you try abi-compliance-checker to see what are the changes in
> API/ABI (if any)?
No - I haven't heard about this tool before.

I am aware about one minor API change (a "char *" parameter was changed to to "const char*"), but I don't think this would break anything.

Anyway ... to be revisited ... May-be we need to bump the SONAME.

> It can be useful for consumers outside Fedora, IIRC
> FreeCAD has been using ANN.
Really? 

# repoquery --archlist=src --whatrequires ann-devel --enablerepo='fedora-source'
and similar queries did not return anything.

Comment 7 Ralf Corsepius 2013-03-22 18:09:12 UTC
OK, abi-compliance-checker complains exactly about this parameter change:

Added Symbols (1)
ANNx.h, libANN.so.1.0
annError ( char const* msg, enum ANNerr level )

Removed Symbols (1)
ANNx.h, libANN.so.1.0
annError ( char* msg, enum ANNerr level )

I.e. ann-1.1.2 is ABI incompatible and is mostly API-compatible (char*->const char* changes often don't have visible impacts).
=> When wanting to be pedantical, an SONAME bump would be required.

When wanting to be "lax" and when taking into account that ann isn't used in Fedora, an SONAME bump could be regarded "negligible".

What do you want to do? I am undecided.

Comment 8 Dan Horák 2013-03-22 20:24:35 UTC
I would keep the soname and noted in update description
"
Beware that void annError(char* msg, enum ANNerr level)
changed to
void annError(char const* msg, enum ANNerr level)
"
so the possible users are warned.

The review request (#459153) shows ann was a dependency of FreeCAD, but is not used anymore.

Comment 9 Fedora Update System 2013-03-24 00:00:10 UTC
Package ann-1.1.2-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ann-1.1.2-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-4313/ann-1.1.2-1.fc18
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2013-08-18 14:20:07 UTC
ann-1.1.2-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/ann-1.1.2-3.fc18

Comment 11 Fedora Update System 2013-08-18 14:20:21 UTC
ann-1.1.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ann-1.1.2-3.fc19

Comment 12 Fedora Update System 2013-08-27 23:24:48 UTC
ann-1.1.2-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2013-08-27 23:37:05 UTC
ann-1.1.2-3.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.