Bug 926969 - ufraw should warn about bogus crop values
Summary: ufraw should warn about bogus crop values
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: ufraw
Version: 18
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:bfaec7656f15a364f73e82694f3...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-24 15:08 UTC by bug-zilla
Modified: 2014-02-05 23:06 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-02-05 23:06:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (37.14 KB, text/plain)
2013-03-24 15:08 UTC, bug-zilla
no flags Details
File: build_ids (902 bytes, text/plain)
2013-03-24 15:09 UTC, bug-zilla
no flags Details
File: cgroup (128 bytes, text/plain)
2013-03-24 15:09 UTC, bug-zilla
no flags Details
File: core_backtrace (894 bytes, text/plain)
2013-03-24 15:09 UTC, bug-zilla
no flags Details
File: dso_list (2.48 KB, text/plain)
2013-03-24 15:10 UTC, bug-zilla
no flags Details
File: environ (3.18 KB, text/plain)
2013-03-24 15:10 UTC, bug-zilla
no flags Details
File: limits (1.29 KB, text/plain)
2013-03-24 15:10 UTC, bug-zilla
no flags Details
File: maps (10.36 KB, text/plain)
2013-03-24 15:10 UTC, bug-zilla
no flags Details
File: open_fds (187 bytes, text/plain)
2013-03-24 15:10 UTC, bug-zilla
no flags Details
File: proc_pid_status (937 bytes, text/plain)
2013-03-24 15:10 UTC, bug-zilla
no flags Details
File: var_log_messages (312 bytes, text/plain)
2013-03-24 15:10 UTC, bug-zilla
no flags Details

Description bug-zilla 2013-03-24 15:08:49 UTC
Description of problem:
It happend on command:
ufraw-batch --out-type=jpg --crop-left=2 --crop-bottom=2 --crop-right=2 --crop-top=2  --compression=100 --overwrite 005.mrw
Original MRW image size is 2568x1928 

Version-Release number of selected component:
ufraw-0.19-1.fc18

Additional info:
backtrace_rating: 4
cmdline:        ufraw-batch --out-type=jpg --crop-left=2 --crop-bottom=2 --crop-right=2 --crop-top=2 --compression=100 --overwrite 005.mrw
crash_function: alloc_sarray
executable:     /usr/bin/ufraw-batch
kernel:         3.8.4-202.fc18.x86_64
uid:            1000

Truncated backtrace:
Thread no. 1 (6 frames)
 #0 alloc_sarray at jmemmgr.c:435
 #1 jinit_c_prep_controller at jcprepct.c:348
 #2 jinit_compress_master at jcinit.c:39
 #3 jpeg_start_compress at jcapistd.c:50
 #4 ufraw_write_image at ufraw_writer.c:444
 #5 ufraw_batch_saver at ufraw-batch.c:155

Comment 1 bug-zilla 2013-03-24 15:08:57 UTC
Created attachment 715526 [details]
File: backtrace

Comment 2 bug-zilla 2013-03-24 15:09:36 UTC
Created attachment 715527 [details]
File: build_ids

Comment 3 bug-zilla 2013-03-24 15:09:44 UTC
Created attachment 715528 [details]
File: cgroup

Comment 4 bug-zilla 2013-03-24 15:09:49 UTC
Created attachment 715529 [details]
File: core_backtrace

Comment 5 bug-zilla 2013-03-24 15:10:09 UTC
Created attachment 715530 [details]
File: dso_list

Comment 6 bug-zilla 2013-03-24 15:10:11 UTC
Created attachment 715531 [details]
File: environ

Comment 7 bug-zilla 2013-03-24 15:10:16 UTC
Created attachment 715532 [details]
File: limits

Comment 8 bug-zilla 2013-03-24 15:10:19 UTC
Created attachment 715533 [details]
File: maps

Comment 9 bug-zilla 2013-03-24 15:10:21 UTC
Created attachment 715534 [details]
File: open_fds

Comment 10 bug-zilla 2013-03-24 15:10:24 UTC
Created attachment 715535 [details]
File: proc_pid_status

Comment 11 bug-zilla 2013-03-24 15:10:29 UTC
Created attachment 715536 [details]
File: var_log_messages

Comment 12 Nils Philippsen 2013-07-31 09:58:28 UTC
Sorry for the long wait. I could reproduce the error here with a testing input file of my own. I guess that there's an error in the calculation of cropped image dimension as ufraw calls libjpeg to compress an image with zero width:

#4  0x000000000041d7ad in ufraw_write_image (uf=0x2559ff0) at ufraw_writer.c:444
        cinfo = { [...] image_width = 0, image_height = 1936, [...] }
        out = 0x25b5ee0
        fitsFile = <optimized out>
        confFilename = 0x0
        grayscaleMode = 0
        Crop = {x = 2, y = 0, width = 0, height = 1936}
        BitDepth = 8

Comment 13 Nils Philippsen 2013-07-31 13:37:33 UTC
It seems that your specification of all crop-{left,right,top,bottom} as "2" is wrong -- you need to specify the absolute pixels, not "crop x pixels from the edge". By specifying all the same, you tell ufraw to crop to 0x0 pixels which lets it trip later on.

Of course, ufraw should refuse to do that and warn about it instead.

Comment 14 bug-zilla 2013-08-26 19:42:28 UTC
Thanks for explanation. In latest version of ufraw this operation ends up with floating point error message so it's OK for me.

Comment 15 Fedora End Of Life 2013-12-21 15:26:44 UTC
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 16 Fedora End Of Life 2014-02-05 23:06:32 UTC
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.